Repository navigation
ci: Bind session renewal workflows to protected environment - #522
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AI assistance
Codex (host-configured model).
What changed
Bind the invocation and session-renew verification jobs to the Environment selected by the existing repository variable
FIRSTRADE_STEP5_ENVIRONMENT, using${{ vars.FIRSTRADE_STEP5_ENVIRONMENT }}instead of the literalPROJECT_ID. The variable was read back asfirstrade-step5.The existing branch contains a normal merge of the current
origin/main. The PR diff remains limited to the two job-level Environment declarations.How verified
GCE_METADATA_DISABLED=true NO_GCE_CHECK=truedisables cloud metadata credential discovery; an initial run was interrupted in credential-discovery backoff after 1095 passing tests.git diff --checkpassed.Why
The literal placeholder selects the wrong Environment. Resolve the existing selector without hardcoding or changing repository configuration.
Risk
Protected workflow configuration; independent exact-head review and the existing risk gate still apply. No labels, Secret, IAM, Variable or Environment configuration changed. No workflow dispatch or deployment was performed. Protected Environment credentials and runtime recovery remain unproved.
Publication scan
Central checker
publication-check/2.0-advisory, build83d9d1130377; total matches 1153; matching lines 1148; advisory. Existing tracked-tree findings remain outside this two-line correction. First 20 masked matches:.github/CODEOWNERS:4:/.env.example @<PROJECT_ID>.github/CODEOWNERS:5:/.github/CODEOWNERS @<PROJECT_ID>.github/CODEOWNERS:6:/.github/workflows/ @<PROJECT_ID>.github/CODEOWNERS:7:/application/execution_receipt_adapter.py @<PROJECT_ID>.github/CODEOWNERS:8:/application/execution_service.py @<PROJECT_ID>.github/CODEOWNERS:9:/application/paper_execution_admission.py @<PROJECT_ID>.github/CODEOWNERS:10:/application/paper_execution_command_consumer.py @<PROJECT_ID>.github/CODEOWNERS:11:/runtime_execution_policy.py @<PROJECT_ID>.github/CODEOWNERS:12:/scripts/execution_report_heartbeat.py @<PROJECT_ID>.github/dot-review/review.cjs:106:const token = <REDACTED> core.getIDToken(audienceText); // Exact bytes; URL normalization may change an audience..github/dot-review/review.cjs:190:const <PROJECT_ID> = {...pr,head:{...pr.head,sha:pair.target},base:{...pr.base,sha:pair.base}};.github/dot-review/review.cjs:191:const binding = {...b.binding({repository:trust.repo.full_name,pr:<PROJECT_ID>,policyCommit:trust.commit,files},trust.policySha),.github/dot-review/test-review.cjs:81:const content='<PROJECT_ID> source\n', sourceSHA='d'.repeat(40);.github/dot-review/test-review.cjs:82:const pr={number:7,changed_files:1,commits:1,title:'<PROJECT_ID> change',body:'<PROJECT_ID> body',.github/dot-review/test-review.cjs:100:assert.equal(audience,'https://audience.example.test');return '<PROJECT_ID>-only';},summary};.github/dot-review/test-review.cjs:111:task={id:'<PROJECT_ID>-task',owner:'example/repo',provider:'dot',revision:1,status:'running',request,output:null,artifacts:[]};.github/workflows/diagnose-cached-stage-failure.yml:52:GCP_PROJECT_ID: <PROJECT_ID>.github/workflows/diagnose-cached-stage-failure.yml:53:GCP_WORKLOAD_IDENTITY_PROVIDER: projects/<PROJECT_NUMBER>/locations/global/workloadIdentityPools/<PROJECT_ID>-actions/providers/<PROJECT_ID>-main.github/workflows/diagnose-cached-stage-failure.yml:54:GCP_WORKLOAD_IDENTITY_SERVICE_ACCOUNT: firstrade-platform-deploy@<PROJECT_ID>.iam.gserviceaccount.com.github/workflows/diagnose-cached-stage-failure.yml:69:id-token: <REDACTED>