Repository navigation
fix: Preserve failed dry-run exception receipts - #520
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Refresh the review for the synchronized Draft head. The original two-file receipt patch is unchanged. Focused tests: 12 passed and 13 subtests passed; full suite: 1841 passed and 118 subtests passed with NO_GCE_CHECK=true on the credential-free development host; repository Ruff and whitespace checks passed. Keep this PR in Draft. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Fix dry-run exception receipts so failures remain
failed/not_applicable, independent of shared resolver precedence. Preserve live submission uncertainty. Only the receipt adapter and its regression tests change.Validation and baseline-red publication exception
Owner t1234s7059 A explicitly authorizes Draft publication only. Exact baseline: 576e533; candidate: 86427ce (full head in PR metadata). Main has not advanced. Python 3.12.15, unchanged frozen lock, explicit original sibling-source paths.
Fresh baseline: 19 failed, 1477 passed, 21 errors, 118 subtests passed. Candidate: 18 failed, 1479 passed, 21 errors, 118 subtests passed. Exact failed/error identity comparison: introduced=0, resolved=1 (the dry-run receipt integrity regression), retained=39 missing-shared-module environment failures. Full suite remains RED. Focused receipt tests: 12 passed, 13 subtests passed; Ruff and whitespace checks pass.
The earlier frozen-installed baseline suite was interrupted after 160.19 seconds in urllib3 connection handling (1097 passed, exit 2): INCOMPLETE, never PASS. No green frozen candidate full suite is claimed. This exception is valid only for this candidate/base/tree/environment and invalidates on drift. Native required checks remain unchanged; publication grants no merge or deploy permission.
Risk and self-review
Fail-closed regression failed before and passed after on the original-source path. Live exception uncertainty regression passes. No new logging, identifiers, persistent state, concurrency or snapshot handling. No workflow, trading gate, dependency, Secret or IAM changes. Runtime adoption is unverified.
AI disclosure
Prepared with OpenAI Codex (GPT-6 family; exact model managed by host).
Central publication check
publication-check/2.0-advisory, build 83d9d1130377, advisory exit 0; total findings 1154, matching lines 1149. Existing tree findings are advisory. First 20 masked matches:
@codex review