Skip to content

feat: add OIDC Dot review submission and collection - #493

Merged
Pigbibi merged 2 commits into
mainfrom
feat/dot-review-first-batch-20261101
Nov 1, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
feat/dot-review-first-batch-20261101

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

AI assistance

Implemented with OpenAI Codex. An independent read-only Codex subagent reviewed all eight changed files at the final head and independently reran the offline tests. This is a local technical review, not a live Dot service run.

What changed

Add trusted default-branch GitHub OIDC submission and manual collection for SHA-bound Dot reviews. Premerge uses the current head/base; posthoc binds the merged commit and its single parent. Collection validates project, request, provider, attempt, revision and current evidence, then updates one bot draft.

Fix uncertain-submit recovery: find an existing intent for the review kind and target SHA before rebuilding CI/model materials. Use its original key/hash for lookup and restore the original frozen request from the task. A missing lookup, mismatched request or changed binding stops recovery. CI reruns and model-setting changes cannot create a replacement intent or another POST.

Readiness and automatic submission stay off. There is no schedule in the submit/collect workflows. The existing governance gate is unchanged.

How verified

  • Eleven offline tests passed locally and in the independent review, covering premerge/posthoc, lost POST responses, unavailable lookup, new runners, changed CI IDs and model settings, request mismatches and stale binding.
  • The regression asserts exactly one POST, one intent, the original frozen request/key/hash, and GET-only recovery. Before the fix, the uncertain premerge case reproduced two POSTs.
  • actionlint passed for both new workflows and the updated CI workflow.
  • Ruff and git diff checks passed. Documentation check had zero blocking findings and one existing README-outline advisory.
  • Remote CI and governance are evaluated on this final head before merge. Local full Python suites were not rerun for this JavaScript recovery fix.

Production admission, audience/model and active subscriptions remain unverified. These are conditions for future enablement, not evidence supplied by this code merge. No real Dot task, deployment, cloud/IAM change or secret change was performed.

Pigbibi and others added 2 commits November 1, 2026 16:54
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi marked this pull request as ready for review November 1, 2026 09:25
@Pigbibi Pigbibi added the owner-approved Owner approval for high-risk PRs. AI agents must never apply this label. label Nov 1, 2026 — with ChatGPT Codex Connector
@Pigbibi
Pigbibi merged commit 33b47fe into main Nov 1, 2026
8 of 11 checks passed
@Pigbibi
Pigbibi deleted the feat/dot-review-first-batch-20261101 branch November 1, 2026 09:27
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 86469932-fb67-49db-97d9-f2ab578cd1e5
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pigbibi Pigbibi left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex self-review of the eight-file implementation: trusted main-only execution, separate submit/read OIDC roles, bounded complete material collection, fixed merge-parent posthoc binding, durable intent before one POST, lookup-only recovery, and bot-only result publication were inspected. Nine offline cases and workflow lint passed. The review fixed exact-audience preservation, commit-file pagination, source-blob identity checks, and result-publication revalidation before this commit. No additional blocking code finding was identified in this self-review. This is not an independent Dot review or an R2 approval. Production admission/subscription verification and existing governance approval remain unresolved; do not merge or enable based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval for high-risk PRs. AI agents must never apply this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant