Repository navigation
feat: add OIDC Dot review submission and collection - #493
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Pigbibi
left a comment
There was a problem hiding this comment.
Codex self-review of the eight-file implementation: trusted main-only execution, separate submit/read OIDC roles, bounded complete material collection, fixed merge-parent posthoc binding, durable intent before one POST, lookup-only recovery, and bot-only result publication were inspected. Nine offline cases and workflow lint passed. The review fixed exact-audience preservation, commit-file pagination, source-blob identity checks, and result-publication revalidation before this commit. No additional blocking code finding was identified in this self-review. This is not an independent Dot review or an R2 approval. Production admission/subscription verification and existing governance approval remain unresolved; do not merge or enable based on this comment.
AI assistance
Implemented with OpenAI Codex. An independent read-only Codex subagent reviewed all eight changed files at the final head and independently reran the offline tests. This is a local technical review, not a live Dot service run.
What changed
Add trusted default-branch GitHub OIDC submission and manual collection for SHA-bound Dot reviews. Premerge uses the current head/base; posthoc binds the merged commit and its single parent. Collection validates project, request, provider, attempt, revision and current evidence, then updates one bot draft.
Fix uncertain-submit recovery: find an existing intent for the review kind and target SHA before rebuilding CI/model materials. Use its original key/hash for lookup and restore the original frozen request from the task. A missing lookup, mismatched request or changed binding stops recovery. CI reruns and model-setting changes cannot create a replacement intent or another POST.
Readiness and automatic submission stay off. There is no schedule in the submit/collect workflows. The existing governance gate is unchanged.
How verified
Production admission, audience/model and active subscriptions remain unverified. These are conditions for future enablement, not evidence supplied by this code merge. No real Dot task, deployment, cloud/IAM change or secret change was performed.