Repository navigation
fix: publish digest candidates before the central daily read - #486
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Pigbibi
marked this pull request as ready for review
November 1, 2026 07:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex (GPT-6).
What changed
The scheduled heartbeat can start after the central 07:00 Asia/Shanghai read, and candidate publication shares a job with unrelated monitoring work. Add a disabled-by-default, archive-only Cloud Run Job entrypoint that reuses the existing producer, requires a single complete target binding, enforces the completed-window publication deadline, and verifies the exact candidate object after writing. Add fixed persistence-stage/error-category diagnostics without exposing exception text.
Document the proposed 06:10 Cloud Scheduler trigger, ten-minute task timeout and zero automatic retries. This PR does not deploy or configure any job, change IAM, send notifications or change trading behavior. Firstrade's historical persistence subcause remains unproven until the diagnostic path is observed; no speculative permission fix is applied.
How verified
29 final entrypoint/integration tests passed. A focused notification/storage regression run passed 71 tests (overlapping the earlier entrypoint suite). Ruff, documentation style checks and git diff checks passed. The style checker reports one existing non-blocking README advisory. All test storage and source reports are synthetic; no production publishing, deployment or natural 07:00 acceptance was performed.