Skip to content

fix: publish digest candidates before the central daily read - #486

Merged
Pigbibi merged 1 commit into
mainfrom
fix/digest-before-read-20261101
Nov 1, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
fix/digest-before-read-20261101

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

AI assistance

OpenAI Codex (GPT-6).

What changed

The scheduled heartbeat can start after the central 07:00 Asia/Shanghai read, and candidate publication shares a job with unrelated monitoring work. Add a disabled-by-default, archive-only Cloud Run Job entrypoint that reuses the existing producer, requires a single complete target binding, enforces the completed-window publication deadline, and verifies the exact candidate object after writing. Add fixed persistence-stage/error-category diagnostics without exposing exception text.

Document the proposed 06:10 Cloud Scheduler trigger, ten-minute task timeout and zero automatic retries. This PR does not deploy or configure any job, change IAM, send notifications or change trading behavior. Firstrade's historical persistence subcause remains unproven until the diagnostic path is observed; no speculative permission fix is applied.

How verified

29 final entrypoint/integration tests passed. A focused notification/storage regression run passed 71 tests (overlapping the earlier entrypoint suite). Ruff, documentation style checks and git diff checks passed. The style checker reports one existing non-blocking README advisory. All test storage and source reports are synthetic; no production publishing, deployment or natural 07:00 acceptance was performed.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5571a407-d00b-4590-8694-28eb07c2695e
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pigbibi
Pigbibi marked this pull request as ready for review November 1, 2026 07:19
@Pigbibi Pigbibi added the owner-approved Owner approval for high-risk PRs. AI agents must never apply this label. label Nov 1, 2026 — with ChatGPT Codex Connector
@Pigbibi
Pigbibi merged commit e97cad6 into main Nov 1, 2026
10 checks passed
@Pigbibi
Pigbibi deleted the fix/digest-before-read-20261101 branch November 1, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval for high-risk PRs. AI agents must never apply this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant