Repository navigation
docs: propose explicit runtime monitoring dependencies - #298
Merged
Merged
Conversation
Pigbibi
marked this pull request as ready for review
October 31, 2026 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the declared-install gap in runtime monitoring dependencies and propose
a bounded packaging correction. This is a documentation-only change; the ADR
remains proposed.
Why
Crypto's normal entrypoint imports QPK's performance monitor. At the consumed
QPK revision, that path imports Pandas and NumPy while the normal dependency
metadata does not declare them. Existing CI installs both libraries separately,
and one entrypoint check can skip when Pandas is absent. Those checks do not
establish that a normal wheel installation is sufficient.
Changes
requirements, a clean-install validation plan and rollback.
version constraints or changing the QPK pin.
an import inside a best-effort handler can change failure behavior.
Testing
README outline advisory as the baseline.
diff were checked;
git diff --checkpasses for the candidate diff.A clean wheel import experiment has not been run. Static source evidence is
not presented as a reproduced production failure. Runtime, package metadata,
dependencies, locks and workflows are unchanged.
Risk and rollback
The proposal requires a later decision between a normal dependency declaration,
a shared-package monitoring extra, or separating monitoring from strategy
imports first. Dependency constraints and consumer adoption need their own
compatibility review. Revert the documentation commit to withdraw the proposal.
Breaking changes
None.
Independent review
A separate reviewer checked the exact three-file candidate, all seven fixed source references, the dependency ownership alternatives and the validation limits. No blocking findings remained. All three checks on the reviewed PR head have completed successfully.
CI results
Checks associated with head
5fb9cffaa7e706d664498307c9417efebcc07f6dare green:GitHub tested the synthetic PR merge with current main; the intervening main change only adds repository-file guidance in
AGENTS.md. The proposed documentation files match the reviewed blobs. The PR remains a draft and is unmerged.CI installs NumPy and Pandas explicitly. These green results do not establish a complete normal-install dependency closure or approve the proposed dependency correction.