Repository navigation
fix: Unify report and candidate execution facts - #678
Conversation
|
@codex review Please review the exact head eb7ed11 against main, covering all six files. Focus on report/candidate field consistency, fail-closed status mapping, unknown-versus-empty observation semantics and preservation of source conflict/CAS behavior. Full offline suite: 5,185 passed, 1 skipped, 403 subtests passed. Draft only; no deployment or merge is requested by this worker. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…field-consistency
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ac31287ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7be16c9b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review exact head 94344ba, including the complete PR diff. Both new P2 findings are addressed with fail-before/pass-after regressions. Full offline suite: 5,282 passed, 1 skipped, 411 subtests passed; focused tests: 389 passed. AI author: Codex (gpt-6.1-sol). Draft remains unchanged; merge and deployment are separate operations. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
added
the
agent-approved
ChatGPT Codex Connector
AI assistance
Codex; exact host model identifier is not exposed. Independent review is requested from the established review bot and is not preclaimed.
What changed
Use one execution summary builder for early notification candidates and completed archives. Preserve current-run plugin observation counts, including the distinction between unknown (absent) and observed-empty (
{}). Map blocked, failed and unknown execution to outererrorwhile preserving precise inner execution status and the runtime_report.v1 vocabulary.How verified
ok; the regression now requireserror.Why
The incident diagnosis showed unequal canonical execution_status and routine_observation_counts for the same source run. Current main already preserves inner status and merges summary fields; consolidation prevents producer drift without equating missing facts with empty observations. Existing contradictory historical candidates remain conflicts and are not rewritten.
Read-only upstream equity tracing used the isolated RO service-account configuration after SG egress verification. The archived account observation contains net_assets and cash fields, but the archive lacks the original broker response and execution portfolio. Source tracing reaches finite broker liquidationValue through QPK's snapshot adapter and the existing sleeve alignment; accepted incident equity provenance remains unproved. No equity mapping or fallback was changed.
Risk
High: runtime report assembly and notification projection only. Recognized submission outcomes remain distinct from fills and reconciliation. HTTP completion is separate from report execution health. Source identity checks, factual conflict rejection, CAS, durable execution claims and trading/risk gates are unchanged. Draft only: no merge, labels, deployment, configuration, Secret, IAM, Scheduler, live/Kelly/stop-loss change or historical object rewrite.
Publication checker
Central publication-check/2.0-advisory, build 83d9d1130377: 1676 findings, 1661 matching lines in the complete tracked tree (advisory). No new identifying constants were added. First 20 masked matches:
.env.example:9:SCHWAB_API_KEY=<<HOST>>.env.example:10:SCHWAB_APP_SECRET=<<HOST>>.env.example:15:TELEGRAM_TOKEN=<<HOST>>.env.example:44:STRATEGY_PLUGIN_ALERT_TELEGRAM_BOT_TOKEN=<<HOST>>.github/CODEOWNERS:9:/.env.example @<PROJECT_ID>.github/CODEOWNERS:10:/.github/CODEOWNERS @<PROJECT_ID>.github/CODEOWNERS:11:/application/account_new_risk_gate_support.py @<PROJECT_ID>.github/CODEOWNERS:12:/application/execution_claim.py @<PROJECT_ID>.github/CODEOWNERS:13:/application/execution_event_accounting.py @<PROJECT_ID>.github/CODEOWNERS:14:/application/execution_intent_continuity.py @<PROJECT_ID>.github/CODEOWNERS:15:/application/execution_kernel_adapter.py @<PROJECT_ID>.github/CODEOWNERS:16:/application/execution_receipt_adapter.py @<PROJECT_ID>.github/CODEOWNERS:17:/application/execution_service.py @<PROJECT_ID>.github/CODEOWNERS:18:/application/offline_execution_event_acceptance.py @<PROJECT_ID>.github/CODEOWNERS:19:/application/paper_execution_admission.py @<PROJECT_ID>.github/CODEOWNERS:20:/application/paper_execution_command_consumer.py @<PROJECT_ID>.github/CODEOWNERS:21:/runtime_execution_policy.py @<PROJECT_ID>.github/CODEOWNERS:22:/scripts/execution_report_heartbeat.py @<PROJECT_ID>.github/CODEOWNERS:23:/scripts/inspect_schwab_token_secret_readiness.py @<PROJECT_ID>.github/CODEOWNERS:24:/scripts/run_offline_execution_event_acceptance.py @<PROJECT_ID>