fix(ci): clear prod audit failures via transitive overrides - #58
Merged
Conversation
The release-artifacts job fails at `npm run audit:prod` because three transitive dependencies resolve to versions inside published advisory ranges: fast-uri 3.1.5 (host confusion and SSRF), hono 4.13.0 (path traversal, parseBody memory exhaustion, query parser fragment handling), and qs 6.15.2 pulled in through express and body-parser. Raise the existing exact-pin overrides to fast-uri 3.1.7 and hono 4.13.7, and pin qs to 6.16.0 so `npm audit --omit=dev` reports zero vulnerabilities again. All three stay within the semver ranges their dependents declare, so no direct dependency changes are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-artifactsfails onmainand on chore(dev): make the plugin bundle debuggable in Obsidian #57 at thenpm run audit:prodstep. The failure is pre-existing and unrelated to any pending feature work: three transitive dependencies resolve to versions inside published advisory ranges.npm audit --omit=devreports zero vulnerabilities again:fast-uri3.1.5 → 3.1.7 (host confusion, IPv6/percent-decoding SSRF — GHSA-5jgf-p345-68v8 and friends)hono4.13.0 → 4.13.7 (toSSG()path traversal,parseBody()memory exhaustion, query parser fragment differential)qs→ 6.16.0, newly pinned; it was resolving to 6.15.2 throughexpressandbody-parser(array-limit bypass,isBufferDoS)ajvwantsfast-uri ^3.0.1,@hono/node-serverpeershono ^4,express/body-parserwantqs ^6.14.0/^6.15.2), so no direct dependency or source changes are required.package-lock.jsonchurn is limited to these packages plusqs's ownside-channelbump.Dev-only advisories are intentionally left alone:
security.ymldocuments thataudit:prodis the gate, and@humanfs/node,baseline-browser-mapping,browserslistandjs-yamldo not reach the shipped bundle.Test plan
npm cisucceeds, confirming the lockfile is consistent withpackage.jsonnpm run audit:prod→found 0 vulnerabilitiesnpm run typechecknpm run lintnpm run buildandnpm run release:check→Release 1.0.7 is ready.npm test→ 160 suites, 3486 tests passedrelease-artifactsjob