Skip to content

feat(api)!: rename YXWaterLevel enum values to mirror v1 values #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lash-L merged 1 commit into from
Mar 22, 2026
Merged

feat(api)!: rename YXWaterLevel enum values to mirror v1 values #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions roborock/data/b01_q10/b01_q10_code_mappings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@ class YXFanLevel(RoborockModeEnum):

class YXWaterLevel(RoborockModeEnum):
UNKNOWN = "unknown", -1
CLOSE = "close", 0
OFF = "off", 0 # close
LOW = "low", 1
MIDDLE = "middle", 2
MEDIUM = "medium", 2 # middle
HIGH = "high", 3


Expand Down
2 changes: 1 addition & 1 deletion tests/protocols/test_b01_q10_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def test_decode_unknown_dps_code() -> None:
(B01_Q10_DP.REQUEST_DPS, {}),
(B01_Q10_DP.REQUEST_DPS, None),
(B01_Q10_DP.START_CLEAN, {"cmd": 1}),
(B01_Q10_DP.WATER_LEVEL, YXWaterLevel.MIDDLE.code),
(B01_Q10_DP.WATER_LEVEL, YXWaterLevel.MEDIUM.code),
],
)
def test_encode_mqtt_payload(command: B01_Q10_DP, params: dict[str, Any], snapshot) -> None:
Expand Down
Loading