-
Notifications
You must be signed in to change notification settings - Fork 78
Harmonizes Q10 status names in python-roborock to canonical values instead of legacy *state strings
#793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
allenporter
merged 4 commits into
Python-roborock:main
from
lboue:fix/normalize-q10-status-state-names
Mar 22, 2026
Merged
Harmonizes Q10 status names in python-roborock to canonical values instead of legacy *state strings
#793
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
edadf18
fix(q10): normalize status names to canonical values
lboue 7fddf43
fix(q10): normalize YXDeviceState status names to canonical values
lboue 393c4e5
fix(q10): refactor test for canonical status names using a dictionary
lboue 7bc1548
fix(q10): add tests for Q10 status values and code mappings
lboue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| """Test cases for B01 Q10 containers.""" | ||
|
|
||
| from roborock.data.b01_q10 import YXDeviceState | ||
|
|
||
|
|
||
| def test_q10_status_values_are_canonical() -> None: | ||
| """Q10 status enum values should expose canonical names.""" | ||
| assert YXDeviceState.SLEEP_STATE.value == "sleeping" | ||
|
lboue marked this conversation as resolved.
Outdated
|
||
| assert YXDeviceState.STANDBY_STATE.value == "standby" | ||
| assert YXDeviceState.CLEANING_STATE.value == "cleaning" | ||
| assert YXDeviceState.TO_CHARGE_STATE.value == "going_to_charge" | ||
| assert YXDeviceState.REMOTEING_STATE.value == "remote_control" | ||
| assert YXDeviceState.CHARGING_STATE.value == "charging" | ||
| assert YXDeviceState.PAUSE_STATE.value == "paused" | ||
| assert YXDeviceState.FAULT_STATE.value == "fault" | ||
| assert YXDeviceState.UPGRADE_STATE.value == "updating" | ||
| assert YXDeviceState.CREATING_MAP_STATE.value == "creating_map" | ||
| assert YXDeviceState.MAP_SAVE_STATE.value == "saving_map" | ||
| assert YXDeviceState.RE_LOCATION_STATE.value == "relocating" | ||
| assert YXDeviceState.ROBOT_SWEEPING.value == "sweeping" | ||
| assert YXDeviceState.ROBOT_MOPING.value == "mopping" | ||
| assert YXDeviceState.ROBOT_SWEEP_AND_MOPING.value == "sweep_and_mop" | ||
| assert YXDeviceState.ROBOT_TRANSITIONING.value == "transitioning" | ||
| assert YXDeviceState.ROBOT_WAIT_CHARGE.value == "waiting_to_charge" | ||
|
|
||
|
|
||
| def test_q10_status_codes_map_to_canonical_values() -> None: | ||
| """Code-based mapping should return canonical status values.""" | ||
| assert YXDeviceState.from_code(5) is YXDeviceState.CLEANING_STATE | ||
| assert YXDeviceState.from_code(8) is YXDeviceState.CHARGING_STATE | ||
| assert YXDeviceState.from_code(14) is YXDeviceState.UPGRADE_STATE | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.