Fix/q10-fault-vacuum-error#792
Merged
Lash-L merged 1 commit intoPython-roborock:mainfrom Mar 21, 2026
Merged
Conversation
Expose dpFault in Q10Status so integrations can read Q10 vacuum error information and add test coverage for refresh parsing.
lboue
force-pushed
the
fix/q10-fault-vacuum-error
branch
from
ad5db23 to
24e3a92
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for the Q10 (B01) vacuum fault/error datapoint by exposing it on the Q10Status container and validating parsing via the existing status trait refresh test.
Changes:
- Added
faulttoQ10Status, mapped toB01_Q10_DP.FAULT(dpFault, DPS 90). - Extended Q10 status trait refresh test to assert
faultisNoneinitially and correctly parsed after refresh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
roborock/data/b01_q10/b01_q10_containers.py |
Adds fault field to the Q10 status dataclass using the established DPS metadata mapping. |
tests/devices/traits/b01/q10/test_status.py |
Updates refresh test assertions to cover the new fault status field and confirm correct parsing from test payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
faultfield toQ10Statusinpython-roborock, mapped toB01_Q10_DP.FAULT(dpFault, DPS90).faultis present and correctly parsed during refresh.