Skip to content

fix: add missing DPS fields to Q10Status and fix CLEAN_PROGRESS mapping #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenporter merged 2 commits into from
Mar 21, 2026
Merged

fix: add missing DPS fields to Q10Status and fix CLEAN_PROGRESS mapping #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de45199
fix: add missing DPS fields to Q10Status and fix CLEAN_PROGRESS mapping
lboue Mar 21, 2026
a4220a0
fix: correct comment for fan level in test_status_trait_refresh
lboue Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion roborock/data/b01_q10/b01_q10_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,14 @@ class Q10Status(RoborockBase):
fan_level: YXFanLevel | None = field(default=None, metadata={"dps": B01_Q10_DP.FAN_LEVEL})
water_level: YXWaterLevel | None = field(default=None, metadata={"dps": B01_Q10_DP.WATER_LEVEL})
clean_count: int | None = field(default=None, metadata={"dps": B01_Q10_DP.CLEAN_COUNT})
total_clean_area: int | None = field(default=None, metadata={"dps": B01_Q10_DP.TOTAL_CLEAN_AREA})
total_clean_count: int | None = field(default=None, metadata={"dps": B01_Q10_DP.TOTAL_CLEAN_COUNT})
total_clean_time: int | None = field(default=None, metadata={"dps": B01_Q10_DP.TOTAL_CLEAN_TIME})
main_brush_life: int | None = field(default=None, metadata={"dps": B01_Q10_DP.MAIN_BRUSH_LIFE})
side_brush_life: int | None = field(default=None, metadata={"dps": B01_Q10_DP.SIDE_BRUSH_LIFE})
filter_life: int | None = field(default=None, metadata={"dps": B01_Q10_DP.FILTER_LIFE})
sensor_life: int | None = field(default=None, metadata={"dps": B01_Q10_DP.SENSOR_LIFE})
clean_mode: YXDeviceWorkMode | None = field(default=None, metadata={"dps": B01_Q10_DP.CLEAN_MODE})
clean_task_type: YXDeviceCleanTask | None = field(default=None, metadata={"dps": B01_Q10_DP.CLEAN_TASK_TYPE})
back_type: YXBackType | None = field(default=None, metadata={"dps": B01_Q10_DP.BACK_TYPE})
cleaning_progress: int | None = field(default=None, metadata={"dps": B01_Q10_DP.CLEANING_PROGRESS})
cleaning_progress: int | None = field(default=None, metadata={"dps": B01_Q10_DP.CLEAN_PROGRESS})
13 changes: 12 additions & 1 deletion tests/devices/traits/b01/q10/test_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,14 @@ async def test_status_trait_refresh(
assert q10_api.status.battery is None
assert q10_api.status.status is None
assert q10_api.status.fan_level is None
assert q10_api.status.total_clean_count is None
assert q10_api.status.main_brush_life is None
assert q10_api.status.cleaning_progress is None

# Mock the response to refresh
# battery (122) = 100
# status (121) = 8 (CHARGING_STATE)
# fun_level (123) = 2 (NORMAL)
# fan_level (123) = 2 (BALANCED)
message = build_message(TESTDATA_DP_REQUEST_DPS)

# Send a refresh command
Expand All @@ -140,6 +143,14 @@ async def test_status_trait_refresh(
assert q10_api.status.battery == 100
assert q10_api.status.status == YXDeviceState.CHARGING_STATE
assert q10_api.status.fan_level == YXFanLevel.BALANCED
assert q10_api.status.total_clean_area == 0
assert q10_api.status.total_clean_count == 0
assert q10_api.status.total_clean_time == 0
assert q10_api.status.main_brush_life == 0
assert q10_api.status.side_brush_life == 0
assert q10_api.status.filter_life == 0
assert q10_api.status.sensor_life == 0
assert q10_api.status.cleaning_progress == 100


def test_status_trait_update_listener(q10_api: Q10PropertiesApi) -> None:
Expand Down
Loading