[pull] main from openai:main - #188
Merged
Merged
Conversation
The Responses WebSocket preconnect omission fix needs regression coverage across sync and async clients. Add one test file exercising both paths against real local WebSocket upgrades, so an absent optional query field cannot silently turn into an explicit false value. It also covers false and true when supplied. The file is tests only, with no production, dependency or generated-code changes. Validation on the committed test bytes: - 319/319 selected Responses and WebSocket tests under Pydantic v2. - 319/319 under Pydantic v1. - 2/2 existing live selectors passed. - Changed-file lint and typing checks passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )