Skip to content

fix(naming): correct watermarks-remover to watermark-remover in service strings; align README SynthID row with CONTEXT - #49

Merged
elkaix merged 1 commit into
mainfrom
fix/naming-consistency
Sep 11, 2026
Merged

elkaix merged 1 commit into
mainfrom
fix/naming-consistency

Conversation

@elkaix

@elkaix elkaix commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix persistent watermarks-remover (plural) naming leak in user-visible service strings → watermark-remover:
    • skills/remove-ai-marks/scripts/server.py: module docstring, OpenAPI info.title, HTTP Server: header, startup log
    • skills/remove-ai-marks/scripts/synthid_score_server.py: HTTP Server: header
  • Update tests/test_http_server.py OpenAPI title assertion in lockstep
  • README Layer table: SynthID result class Score onlyScore + best-effort removal, matching CONTEXT.md and the README's own --remove-synthid / --remove-pixel body sections

Verification

  • Full suite: 1076 passed, 6 skipped
  • make lint (ruff): all checks passed
  • py_compile on all edited files: OK
  • No tracked references to the old strings remain (outside gitignored research/)
  • Packaging verified: package-dir maps watermark_removerskills/remove-ai-marks, so edited files are what ships in the wheel

Note

Server: header and OpenAPI title are wire-visible; any client keying on the old watermarks-remover/ prefix would notice — this is the intended correction of the naming bug, not a behavior regression.

Summary by CodeRabbit

  • Documentation

    • Clarified that SynthID pixel-domain processing is available through an optional external adapter.
    • Updated the documented results to include scoring and best-effort watermark removal.
  • Updates

    • Standardized the service name to “watermark-remover” across service metadata, API documentation, server identification, and startup messages.
    • Updated the SynthID scoring service identifier to use the standardized “watermark-remover-synthid” name.

…ce strings; align README SynthID row with CONTEXT

- server.py: docstring, OpenAPI title, Server header, startup log
- synthid_score_server.py: Server header
- test_http_server.py: OpenAPI title assertion (lockstep)
- README SynthID result class now 'Score + best-effort removal',
  matching CONTEXT.md and the --remove-synthid/--remove-pixel body
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 95a9a0a0-4324-449f-a266-e44fe6d83c51

📥 Commits

Reviewing files that changed from the base of the PR and between efedfff and ad837c0.

📒 Files selected for processing (4)
  • README.md
  • skills/remove-ai-marks/scripts/server.py
  • skills/remove-ai-marks/scripts/synthid_score_server.py
  • tests/test_http_server.py

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The change standardizes the service branding to watermark-remover and updates the SynthID documentation to describe scoring and best-effort removal.

Changes

Service branding and SynthID documentation

Layer / File(s) Summary
Standardize service identifiers
skills/remove-ai-marks/scripts/server.py, skills/remove-ai-marks/scripts/synthid_score_server.py, tests/test_http_server.py
The service documentation, OpenAPI title, server-version prefixes, startup log, and test expectation use the singular watermark-remover branding.
Update SynthID adapter description
README.md
The SynthID row documents optional scoring and best-effort removal.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to ad837

The PR standardizes the service name and documents SynthID best-effort removal without identified runtime or integration risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies both main changes: correcting the service name and aligning the README SynthID result description. It is specific and related to the changeset, although it is somewhat lon…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/naming-consistency

Comment @coderabbitai help to get the list of available commands.

@elkaix
elkaix merged commit bd1d075 into main Sep 11, 2026
15 of 19 checks passed
@elkaix
elkaix deleted the fix/naming-consistency branch September 11, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant