Skip to content

test: run minidb outside the default vitest project matrix - #311

Open
elkaix wants to merge 1 commit into
mainfrom
fix/reconcile-rows-c-2026-09-14
Open

elkaix wants to merge 1 commit into
mainfrom
fix/reconcile-rows-c-2026-09-14

Conversation

@elkaix

@elkaix elkaix commented Sep 15, 2026

Copy link
Copy Markdown
Member

Related Issue

No tracked issue — follow-on to the reconciliation stack (#307 / #308).

Problem

The minidb cluster suite shares the root vitest shard matrix. Under CI load, multi-process wait-read cases can time out even when they pass in isolation, and they slow every shard.

What changed

  • Exclude packages/minidb from the root vitest projects glob (!packages/minidb).
  • Add a dedicated test-minidb CI job and require it in the aggregate test gate so coverage stays required.

No product behavior change. No changeset (not user-facing).

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue (external PRs: the issue must have a maintainer's /approve).
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 3 included reviews currently available. Your 79 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 5f6c3ba0-3cba-405d-b3ea-1cb07795835a

📥 Commits

Reviewing files that changed from the base of the PR and between ec99d66 and 2f6f323.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • vitest.config.ts

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@pymodel/pythinker-code@2f6f323
npx https://pkg.pr.new/@pymodel/pythinker-code@2f6f323

commit: 2f6f323

@elkaix
elkaix changed the base branch from fix/reconcile-rows-b-2026-09-10 to main September 15, 2026 00:29
@elkaix
elkaix force-pushed the fix/reconcile-rows-c-2026-09-14 branch from 986b5a0 to 74e5fee Compare September 15, 2026 00:30
@elkaix
elkaix changed the base branch from main to fix/reconcile-rows-b-2026-09-10 September 15, 2026 00:30
Base automatically changed from fix/reconcile-rows-b-2026-09-10 to main September 15, 2026 00:46
Exclude packages/minidb from the root project glob and give it its own CI
job so the heavy cluster suite no longer shares shard load with the rest of
the monorepo.
@elkaix
elkaix force-pushed the fix/reconcile-rows-c-2026-09-14 branch from 74e5fee to 2f6f323 Compare September 15, 2026 00:47
@elkaix

elkaix commented Sep 15, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant