fix(agent-core-v2): keep background questions open past turn end - #308
Open
elkaix wants to merge 2 commits into
Open
fix(agent-core-v2): keep background questions open past turn end#308elkaix wants to merge 2 commits into
elkaix wants to merge 2 commits into
Conversation
A background AskUserQuestion was bound to the asking turn, so the question was cancelled the moment the agent finished its turn and the user never got to answer. Detached requests no longer carry the turn id, and turn-end cancellation leaves them pending. The answer now reaches the agent inline in the task notification instead of only as a saved output path, bounded and xml-escaped.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No tracked issue — internal reconciliation pass. Stacked on #307; review that one first (and #306 under it).
Problem
A background
AskUserQuestion(asked withbackground: true) was bound to the asking turn: the moment the agent finished its turn, the question was cancelled and the user never got to answer it. When a background question was answered, the agent received only the path of a saved output file, not the answer itself.What changed
<answer>block — instead of only a saved output path. Answered and dismissed outcomes get distinct notification text, and the transcript projection keeps background-question answers grouped with their turn.docs/reference/tools.mddocuments thebackgroundbehaviour onAskUserQuestion; two patch changesets included.dist-webmanifest restaged in the same commit (packages/transcriptis a web build input; only.web-bundle-manifest.jsonchanged).Verification on this commit: full pre-push gate (597s, all checks passed), agent-core-v2 suite green, typecheck 0, lint 0, leak-check A–G PASS.
Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.