fix: finalize the update manifest the desktop release channel produces - #305
Merged
Merged
Conversation
The macOS finalize step always read latest-mac.yml, but electron-builder names the manifest after the release channel, so a Nightly build writes nightly-mac.yml. Every Nightly run failed with ENOENT after notarization had already succeeded, leaving the channel unpublished. Pass the channel manifest the prepare job already resolves.
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 72 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Comment |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip changeset] — release-workflow and build-script only; no user-perceivable CLI or app behavior change.
Summary
Every Nightly desktop run has failed since at least 2026-09-08, after notarization had already succeeded:
finalize-mac-artifacts.tsalways readlatest-mac.yml, but electron-builder names the update manifest after the release channel — a Nightly build (0.11.1-nightly.304) writesnightly-mac.yml. That name was already resolved by thepreparejob and consumed by the verify step (needs.prepare.outputs.mac_manifest); only the finalize step still hardcoded the stable name.The DMG was notarized and stapled before the crash, so each failed run also left
Desktop Nightlyunpublished and kept the release-lane drift issue (#202) open.Changes
finalizeMacArtifactstakes an optionalmanifestName, defaulting tolatest-mac.yml, so the stable path and the localrelease-mac.tscaller are unchanged.preparejob already resolves.latest-mac.ymlduring a Nightly incident.Test plan
nightly-mac.ymlfixture and asserts the rewritten checksum.DEFAULT_MAC_MANIFESTmakes the new test fail with the exact CI error (ENOENT ... latest-mac.yml); restoring it passes 8/8.typecheck(desktop, both tsconfigs) andlint(0 errors) pass.