Skip to content

Resolve designer hardening review findings and validate useful dependency fixes #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
elkaix wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Resolve designer hardening review findings and validate useful dependency fixes #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef73daa
ci: isolate checkout credentials and retain reproducible verification…
elkaix Sep 5, 2026
4290be3
build(deps): declare HTML parsers and supported runtime before lock r…
elkaix Sep 5, 2026
560f085
build(deps): resolve reviewed compatible updates and static HTML parsers
github-actions[bot] Sep 5, 2026
fb06f49
docs: record review decisions and remove one-time lock maintenance
elkaix Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,35 @@ jobs:
working-directory: designer-skill-mcp
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: ${{ matrix.node }}
cache: npm
cache-dependency-path: designer-skill-mcp/package-lock.json
- run: npm ci
- name: Capture reproducible inputs
if: ${{ matrix.node == 22 }}
run: |
mkdir -p verification
git -C .. archive --format=tar.gz HEAD > verification/source.tar.gz
tar -czf verification/dependencies.tar.gz node_modules
node --version > verification/runtime.txt
npm --version >> verification/runtime.txt
git rev-parse HEAD >> verification/runtime.txt
- run: npm run build
- run: node --test checks/core.mjs
- run: npm test
- run: node scripts/verify-package.mjs
- name: Retain verification inputs
if: ${{ always() && matrix.node == 22 }}
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: verification-inputs
path: designer-skill-mcp/verification/
if-no-files-found: error
retention-days: 1

# Preserve the existing required branch-protection check name.
test:
Expand All @@ -51,6 +70,8 @@ jobs:
timeout-minutes: 10
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 24
Expand Down
Loading
Loading