Open
Conversation
Add wheel build target configuration for pymodaq_plugins_template.
Contributor
|
did you change the folder within src to be pymodaq_plugins_whateveryourpluginnameis? |
Author
|
I will make a few test again, I think that we probably forgot that on the new plugin but it helped with an old one too. I will check and close the PR if this was a mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
We tried creating a new plugin and it would not install properly with 'pip install -e .'.
The error message suggested to add this at the end of the pyproject.toml :
[tool.hatch.build.targets.wheel]
packages = ["src/pymodaq_plugins_template"]
And it solved the issue. I am not sure that the end of the file is a good place for this though, as it is after the nottodo section. Does the order of the info in the pyproject.toml file matter?