This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Adding comparison of parent in compareStructure/compareValues#125
Merged
seb5g merged 3 commits intoPyMoDAQ:5.0.x_devfrom Nov 3, 2025
Merged
Adding comparison of parent in compareStructure/compareValues#125seb5g merged 3 commits intoPyMoDAQ:5.0.x_devfrom
seb5g merged 3 commits intoPyMoDAQ:5.0.x_devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.0.x_dev #125 +/- ##
=============================================
+ Coverage 64.28% 64.30% +0.01%
=============================================
Files 73 73
Lines 9181 9185 +4
=============================================
+ Hits 5902 5906 +4
Misses 3279 3279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seb5g
reviewed
Nov 3, 2025
Contributor
seb5g
left a comment
There was a problem hiding this comment.
do you know if this induce a breaking change in pymodaq? Could you check the use case of these methods within pymodaq?
Contributor
Author
|
I checked and did not see a direct use of these methods in pymodaq. The tests do not seem affected by it. |
seb5g
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR related to #124
The compareStruct/compareValues do not consider the parent in the boolean output.
The reason for it was to follow the structure of the getValues from pyqtgraph in the getOpts/getStruct methods.
This PR adds the keyword with_self to the compareParameters/compareValuesParameter to take into account the opts/values of the parent parameter in the boolean output.
The default value of with_self is True which means that parent is considered as default behavior.