Preserve resource state across legacy arm pickup and drop - #1194
Open
j0nch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the legacy
LiquidHandlerresource-move path so its resource model reflects a successful physical pickup immediately, while preserving the pickup-time geometry needed for a correct drop.This prevents a detached resource from losing source-parent pose context between pickup and drop.
Scope
Current
mainno longer contains the prior capabilities-arm package, so this PR intentionally covers the active legacy resource-movement implementation only.Test
Adds a regression test for a plate picked up from a rotated source holder. It verifies that the source is released immediately and the drop receives the pickup-time rotation and width.
Validation performed locally:
git diff --checkThe checkout used for this port did not include the project test environment, so
pytestwas not available there.