Conversation
start_encoding() was calling avcodec_open2() on codec contexts created by add_stream_from_template(), fully initializing the codec (e.g. libx264 allocates x264_t, thread pools, reference frames) even when the stream is only used for remuxing and never calls encode()/decode(). After freeing, the C heap retains this memory, causing RSS to grow with each output segment. Add a _template_initialized flag to CodecContext, set by add_stream_from_template(). In start_encoding(), contexts with this flag skip avcodec_open2() — the codec opens lazily via encode() or decode() if actually needed. Fixes #2135 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…False)
start_encoding() was calling avcodec_open2() on encoder codec contexts created by add_stream_from_template(), fully initializing the encoder (e.g. libx264 allocates x264_t, thread pools, reference frames) even when the stream is only used for remuxing and never calls encode(). After freeing, the C heap retains this memory, causing RSS to grow with each output segment.
Add a _template_initialized flag to CodecContext, set by add_stream_from_template(). In start_encoding(), encoder contexts with this flag skip avcodec_open2() — the encoder opens lazily via encode() if actually needed for re-encoding.
Fixes #2135