Verify Chuckie Egg - #759
Open
flaviodnz1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Chuckie Egg (1989) (Pick & Choose)
This is my first PureDOS verification contribution. I tested the DOSZ standalone and also tested the existing DOSC in DOSBox Pure. The game launches and plays correctly, and the DOSC auto-starts the game, sets the CPU year to 1989, and automatically selects EGA.
The game files match the TDC 22 entry for Chuckie Egg. I do not have original installation media available, so I could not independently verify the files against original install media beyond the TDC match and the timestamps present in that source set.
Please let me know if I misunderstood any part of the verification process or if anything else should be checked or changed. I am happy to make any necessary adjustments.
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
Not applicable. The DOSZ does not require a configuration file to run; the DOSC supplies launch configuration.
Have any official patches been applied, if necessary?
No official patch was identified as necessary.
Have digital versions (Steam, GOG) been checked for matching?
Yes. No current GOG or Steam DOS release was identified.
Can the game benefit from using embedded data or embedded patches in the datfile?
No benefit identified.
Can DoDAT build the game from the install media?
Not verified from original install media, because no installation media was available. The promoted fileset matches the TDC 22 source entry.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable. The launch configuration is in the DOSC.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No such files are present in the retained DOSZ fileset.
Do the file timestamps match the installation media?
Original installation media was not available for an independent comparison. The timestamps added here are from the matching TDC source set.
Does the DOSZ run standalone?
Yes. Tested successfully in DOSBox Pure.
For CD games, can the game be set up to run without a CD mounted?
Not applicable.
Can the game benefit from using CHDtoOGG?
Not applicable.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No issue observed during testing.
Does the DOSC contain problematic data (i.e. copyright issue)?
No. It contains only DOS.YML launch configuration.
Does the DOSC have copy protection removed, if possible?
No copy-protection prompt was encountered during testing.
Is the game running at the correct speed? Is CPU year specified?
Yes. cpu_year: 1989 is specified and the game behaved normally during testing.
Is the DOSC auto-running and skipping past any obstructions? Does it use WAITMODECHANGE if possible?
Yes. It auto-runs C:\CHUCKIE.EXE and uses run_input: (WAITMODECHANGE)2 to automatically select EGA.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No MT-32 support was identified.
Does the game have General MIDI support?
No General MIDI support was identified.
Is the game set up to run with the best quality graphics options by default?
Yes. The DOSC automatically selects the EGA option from the game's CGA/EGA/Tandy selector.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
No. EGA is the preferred tested graphics option here.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
Not applicable.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.
Is the entry in the right variant file (i.e. Freeware)?
Yes. This is the standard commercial variant, so it is being moved to PureDOSDAT.xml.
For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable.
Comment
Summary of changes: