fix: enforce Observe approval guard and exact deployment rollback - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observe mode hid the approval button but still allowed Y/y to approve a pending action. Guard both the callback and keyboard handler, and refresh handlers when trust changes.
Deployment rollback previously merged an old ReplicaSet template, retaining newly introduced fields. Replace the complete pod template with JSON Patch, test resourceVersion atomically, and remove the ReplicaSet-owned pod-template-hash label.
Validation: 2,295 tests across 191 files passed, TypeScript and production build passed, ESLint passed with the existing warning backlog. Five new regression cases cover approval after trust changes, removal of introduced template fields, and concurrent-version rejection. Final focused 25 tests and TypeScript passed after callback cleanup. Real-cluster acceptance remains pending.