fix: integrate dependencies and correct Temporal and Secret reconciliation - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the overlapping dependency updates coherently: Kubernetes modules and controller-runtime advance together rather than independently breaking generated validation. Include the image digest, test library, semver, and Prometheus updates represented by the existing dependency PRs, and group Kubernetes updates in Dependabot.
Allow enabled Temporal pods to reach PostgreSQL on TCP5432, revoke that access when disabled, and store nginx Secret configuration in Data so stable reconciliation does not issue redundant updates. Correct installation/trust documentation to match the code.
Validation: complete envtest suite passed, controller coverage80.2% and overall71.8%; Go vet, Linux amd64 build and govulncheck passed. Regression tests simulate Secret API normalization and verify enabled/disabled Temporal access. Combined container scans, catalog smoke and scorecard remain for this PR's CI. Real OpenShift acceptance is pending.
This supersedes dependency changes in #63, #64, #65, #67, #68, #72, #74, #77, #79, #80, #81, #82 after successful integration. Do not merge #81 independently: its isolated apimachinery upgrade breaks compilation. Earlier failures in #63–65 were stale version guards, not failing controller specs.