Conversation
Track each account's settled rewards and credit only the delta from the cumulative total, preventing double-counting when claiming multiple times. Applied to both token and usdt_token contracts.
Assert caller is the deployer in simple_mint to prevent unauthorized minting of USDT.
Drop the pow rewards claim path from the usdt_token precompile along with its mining_rewards dependency and precompiles.json entry. The storage fields are kept as reserved slots to preserve the deployed storage layout.
Require index < 2^proof_height instead of the fixed 2^32 limit, making the leaf-index range check explicit and fail-fast for the actual tree height.
…fer events in batch transfers - token/usdt_token: assert the upper u32 limbs stay within Felt range when decoding a hash to an amount - usdt_token: emit TransferEvent for each non-zero transfer in batch_simple_transfer_2/5
…reads Replace the 256-iteration lookup loops in get_chain_count_value and get_chain_root_value with direct dynamic index access in both deposit_tree and withdrawal_tree. Behavior is unchanged.
Add a PrivateTransferEvent to the token and usdt_token precompiles that emits the note index, commitment, and new note root after a private transfer updates the note tree. Receiver, value, and note_commitment are deliberately excluded to avoid leaking private or linkable data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.