Repository navigation
Conversation
_engine_inputs_from_video dropped req.response_format, so b64_json requests fell back to a pod-local file URL. Image and audio builders already forward the delivery format; T2V and I2V share this path. Signed-off-by: Jasim Kareem <mj9034812@gmail.com> Co-authored-by: Jasim Kareem <mj9034812@gmail.com>
Prudctual
had a problem deploying
to
external_collaborator
September 15, 2026 07:43 — with
GitHub Actions
Failure
Keep video and I2V coverage for b64_json and url. This PR only threads response_format through the video engine path. Signed-off-by: Jasim Kareem <mj9034812@gmail.com> Co-authored-by: Jasim Kareem <mj9034812@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Preserve
response_format=b64_jsonon vLLM-Omni video generation (T2V and I2V) so the formatter returns inline base64 instead of a pod-localfile://URL.This is part A of ai-dynamo#14667 only. The independent FFmpeg color-corruption issue (part B) is out of scope.
Upstream PR could not be opened (403). Open against
ai-dynamo/dynamofrom:https://github.com/ai-dynamo/dynamo/compare/main...Prudctual:dynamo:cursor/omni-video-response-format-fbb4?expand=1
Details:
_engine_inputs_from_video()constructedEngineInputswithoutresponse_format=req.response_format. The output formatter then defaulted tourl, so an explicitb64_jsonrequest completed with only a worker-local file URL.Sibling builders were checked for the same omission (ai-dynamo#14668 shared root cause):
_engine_inputs_from_image): already forwardsreq.response_format.AudioGenerationHandler.build_engine_inputs): already mapsdata_sourcetoEngineInputs.response_format(OpenAI audio usesresponse_formatfor the codec)._engine_inputs_from_video, so the one-line assignment covers it.A unit test now asserts T2V and I2V forward
b64_json/url, plus an image regression check.Where should the reviewer start?
components/src/dynamo/vllm/omni/omni_handler.py(_engine_inputs_from_video)components/src/dynamo/vllm/tests/omni/test_omni_handler.py(test_video_and_i2v_forward_response_format)Related Issues
🔗 This PR is linked to an issue:
Summary
Video omni
EngineInputsnow carryreq.response_format, matching the image path, sob64_jsonis not dropped.Validation
test_omni_handler.pyfor image, T2V, and I2Vresponse_formatforwarding.EngineInputsconstructors passresponse_format=req.response_format.vllm-omniunit suite is intended to run in CI (pytestmarkers:unit,vllm,gpu_0,multimodal,pre_merge). This cloud-agent environment does not havevllm-omniinstalled.Summary by cubic
Fixes vLLM-Omni video generation (T2V and I2V) so
response_format=b64_jsonreturns inline base64 instead of a pod-local file URL._engine_inputs_from_videonow forwardsreq.response_formattoEngineInputs, matching the image and audio builders. Adds unit tests verifyingb64_jsonandurlforwarding for T2V and I2V. Closes ai-dynamo#14667.Written for commit 4ffdc68. Summary will update on new commits.