Skip to content

fix: use a schema for enable_inscription body #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
armanddidierjean wants to merge 1 commit into from
Closed

fix: use a schema for enable_inscription body #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/modules/sport_competition/endpoints_sport_competition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from io import BytesIO
from uuid import UUID, uuid4

from fastapi import Body, Depends, HTTPException, Query, Response
from fastapi import Depends, HTTPException, Query, Response
from fastapi.responses import FileResponse
from sqlalchemy.ext.asyncio import AsyncSession

Expand Down Expand Up @@ -271,12 +271,12 @@ async def activate_edition(
status_code=204,
)
async def enable_inscription(
enable_inscription: schemas_sport_competition.CompetitionEnableInscription,
edition_id: UUID,
db: AsyncSession = Depends(get_db),
user: models_users.CoreUser = Depends(
is_user_allowed_to([SportCompetitionPermissions.manage_sport_competition]),
),
enable: bool = Body(),
) -> None:
"""
Enable inscription for a competition edition.
Expand All @@ -293,7 +293,11 @@ async def enable_inscription(
status_code=400,
detail="Edition is not active, cannot patch inscription",
)
await cruds_sport_competition.patch_edition_inscription(edition_id, enable, db)
await cruds_sport_competition.patch_edition_inscription(
edition_id,
enable_inscription.enable,
db,
)


@module.router.patch(
Expand Down
4 changes: 4 additions & 0 deletions app/modules/sport_competition/schemas_sport_competition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ class CompetitionEditionEdit(BaseModel):
end_date: datetime | None = None


class CompetitionEnableInscription(BaseModel):
enable: bool


class SchoolExtensionBase(BaseModel):
school_id: UUID
from_lyon: bool
Expand Down
4 changes: 2 additions & 2 deletions tests/modules/sport_competition/test_sport_inscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ async def test_enable_inscription_not_active(
response = client.post(
f"/competition/editions/{old_edition.id}/inscription",
headers={"Authorization": f"Bearer {admin_token}"},
json=True,
json={"enable": True},
)
assert response.status_code == 400, response.json()
editions = client.get(
Expand All @@ -1000,7 +1000,7 @@ async def test_enable_inscription(
response = client.post(
f"/competition/editions/{active_edition.id}/inscription",
headers={"Authorization": f"Bearer {admin_token}"},
json=True,
json={"enable": True},
)
assert response.status_code == 204, response.json()
editions = client.get(
Expand Down
Loading