Repository navigation
Conversation
tatuharu
reviewed
Oct 26, 2026
tatuharu
left a comment
tatuharu
left a comment
Member
There was a problem hiding this comment.
このレビューはハルがAI自動レビューの動作テストのためにOpus5.5 Extra Highを使用してレビューを行なったものです。鵜呑みにせず、指摘を採用するかはお任せします。
指摘が 1 件あります。詳細は行コメントに書いています。
- 〔契約〕
$ArtifactSpecialCooldownの公開範囲に改名前の関数名が残り、実際に参照するdebug:artifact/cooldown_resetが含まれていない
| # asset_manager:artifact/use/ | ||
| # asset_manager:artifact/tick/ | ||
| # core:tick/ | ||
| # debug:artifact/cooldown/reset_all |
Member
There was a problem hiding this comment.
2つ目のコミット（b41accd）で関数を debug:artifact/cooldown_reset に改名しましたが、この @within には改名前の debug:artifact/cooldown/reset_all が残っています。PR の head にこの関数はなく、$ArtifactSpecialCooldown を書き換える debug:artifact/cooldown_reset（cooldown_reset.mcfunction の24行目）は、この宣言の公開範囲に含まれていません。
Suggested change
| # debug:artifact/cooldown/reset_all | |
| # debug:artifact/cooldown_reset |
食い違いはコメント内の宣言だけにあり、ゲーム内の動作には表れないため、ゲーム内では確認していません。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.