Repository navigation
fix(apps): explain the new username and password-change limits - #57
Open
Eleanor1018 wants to merge 2 commits into
Open
Eleanor1018 wants to merge 2 commits into
Eleanor1018 wants to merge 2 commits into
Conversation
The API now refuses new usernames containing @ (4005) and rate-limits current-password checks (429). Registration explains the rule beside the field, announces it to VoiceOver and keeps Register disabled, and the store refuses such usernames before touching the session. A server 4005 is no longer reported as a possible duplicate, and a rate-limited password change no longer claims its outcome is uncertain. Existing usernames containing @ still sign in. The account UI fixture gains an opt-in signed-out mode for the registration test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The API now refuses new usernames containing @ (4005). The registration field shows the rule as an announced supporting error and keeps Register disabled, the repository refuses such usernames before any request, and a server 4005 is no longer shown as a generic input error. Existing usernames containing @ still sign in; rate-limited password changes already show the generic too-many-attempts message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying lycoris-map with
|
| Latest commit: |
e0e5894
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://568ebaee.lycoris-map.pages.dev |
| Branch Preview URL: | https://fix-app-account-rules.lycoris-map.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the native apps in line with the account rules added in #56.
iOS. Registration shows "Usernames can't contain @." beside the field, announces it to VoiceOver as it appears and keeps Register disabled; the store refuses such usernames before touching the session. A server 4005 is no longer reported as "that username or email may already be in use". A rate-limited password change (429, code 42934) now says to try again later instead of claiming the outcome could not be confirmed and suggesting a fresh login.
Android. The registration field shows the same rule as an announced supporting error and keeps Register disabled; the repository refuses such usernames before any request, and a server 4005 is no longer shown as a generic input error. Rate-limited password changes already used the generic too-many-attempts message.
Existing usernames containing
@still sign in on both platforms. Both strings are localized in English and Simplified Chinese. No backend or Web change.Validation: iOS 180 unit tests and the account regression UI suite on the iPhone 17 simulator (Test configuration; the fixture gains an opt-in signed-out mode). Android 164 QA unit tests,
lintQa, QA instrumentation APK build, andAccountFormsTeston an API 36 AOSP emulator. The Android workflow runs the full instrumentation suite on this PR.Device check: in the simulator, scripted typing into the registration password field (
.newPassword) keeps only the first character, while the login field accepts the full password; the same happens onmain. The new iOS UI test therefore checks only the rule appearing and clearing, and Register availability is covered by unit tests. Please type a full password on the registration screen on a physical iPhone once.🤖 Generated with Claude Code