Skip to content

fix: remove em dash and stale version claim in zh troubleshooting#551

Merged
hami-robot[bot] merged 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/zh-troubleshooting-content
Jul 5, 2026
Merged

fix: remove em dash and stale version claim in zh troubleshooting#551
hami-robot[bot] merged 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/zh-troubleshooting-content

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Two issues in the zh troubleshooting page:

  • Em dash used in four bullet points, against this repo's style rule.
  • Said v2.3.10 is the latest device-plugin version. Current HAMi is v2.9.0, that claim is years stale. Reworded to match the english source, which states the change happened since v2.3.10 without claiming it is the latest.

Test plan

  • npm run lint:md passes
  • prettier check passes
  • npm run build succeeds for both locales

Summary by CodeRabbit

  • Documentation
    • Clarified the troubleshooting guide for GPU memory limits not taking effect, improving the presentation of possible causes while keeping the original guidance.
    • Updated the version boundary for the device-plugin environment variable change and added clearer recovery steps for manual and Helm-based fixes.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@netlify

netlify Bot commented Jul 5, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit f3662bd
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a4a6503cbd2a900093b3aa2
😎 Deploy Preview https://deploy-preview-551--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot hami-robot Bot added the size/S label Jul 5, 2026
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 667018f9-9155-4ddb-b238-e316220f965c

📥 Commits

Reviewing files that changed from the base of the PR and between 6e4e181 and f3662bd.

📒 Files selected for processing (1)
  • i18n/zh/docusaurus-plugin-content-docs/current/troubleshooting/troubleshooting.md

📝 Walkthrough

Walkthrough

Updates the Chinese troubleshooting documentation: reformats GPU memory limit cause list items to bold-titled bullets, and corrects the device-plugin environment variable rename version reference from v2.3.9 to v2.3.10.

Changes

Troubleshooting Documentation Updates

Layer / File(s) Summary
GPU memory limit reasons formatting
i18n/zh/docusaurus-plugin-content-docs/current/troubleshooting/troubleshooting.md
Converts dash-formatted cause list items to bold-titled bullet points, preserving the four original causes and verification guidance.
Device-plugin version note correction
i18n/zh/docusaurus-plugin-content-docs/current/troubleshooting/troubleshooting.md
Updates the version reference for the NodeName to NODE_NAME rename from v2.3.9 to v2.3.10, keeping both fix instructions (manual kubectl edit or Helm upgrade).

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: lgtm, approved

Suggested reviewers: archlitchi, rootsongjc

Poem

A hop through docs, a fix so small,
Bold bullets stand up straight and tall,
v2.3.10, the version's true,
NODE_NAME shines in clearer view,
This rabbit thumps approval too! 🐰📝

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main doc fixes: removing em dash usage and correcting the stale version claim in the Chinese troubleshooting page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@hami-robot

hami-robot Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mesutoezdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot merged commit 0a55c4e into Project-HAMi:master Jul 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant