-
Notifications
You must be signed in to change notification settings - Fork 54
fix: enable Ascend NPU container-level metrics in exporter and chart display #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pingxin403
wants to merge
2
commits into
Project-HAMi:main
Choose a base branch
from
pingxin403:feat/ascend-npu-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+119
−17
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| package exporter | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "io" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "strings" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "vgpu/internal/biz" | ||
| "vgpu/internal/data/prom" | ||
| "vgpu/internal/service" | ||
|
|
||
| "github.com/go-kratos/kratos/v2/log" | ||
| ) | ||
|
|
||
| // testPromHandler returns a handler that acts as a fake Prometheus /api/v1/query | ||
| // endpoint. When value is non-empty, it returns a single-sample vector with that | ||
| // value. When value is empty, it returns an empty result vector. | ||
| func testPromHandler(t *testing.T, value string) http.HandlerFunc { | ||
| return func(w http.ResponseWriter, r *http.Request) { | ||
| if r.Method != http.MethodPost && r.Method != http.MethodGet { | ||
| t.Errorf("unexpected method: %s", r.Method) | ||
| } | ||
| if !strings.HasSuffix(r.URL.Path, "/api/v1/query") { | ||
| t.Errorf("unexpected path: %s", r.URL.Path) | ||
| } | ||
| w.Header().Set("Content-Type", "application/json") | ||
| if value == "" { | ||
| fmt.Fprint(w, `{"status":"success","data":{"resultType":"vector","result":[]}}`) | ||
| return | ||
| } | ||
| fmt.Fprintf(w, `{"status":"success","data":{"resultType":"vector","result":[{"metric":{},"value":[1719500000,%q]}]}}`, value) | ||
| } | ||
| } | ||
|
|
||
| // newTestGenerator starts an httptest server with the given handler, creates a | ||
| // prom.Client pointed at it, wraps it in a MonitorService, and returns a bare | ||
| // MetricsGenerator (other fields left nil). The returned close func shuts down | ||
| // the test server. | ||
| func newTestGenerator(t *testing.T, handler http.HandlerFunc) (*MetricsGenerator, func()) { | ||
| srv := httptest.NewServer(handler) | ||
|
|
||
| promClient, err := prom.NewClient(srv.URL, time.Second, "") | ||
| if err != nil { | ||
| srv.Close() | ||
| t.Fatalf("prom.NewClient: %v", err) | ||
| } | ||
|
|
||
| monitorSvc := service.NewMonitorService(promClient, nil, nil) | ||
|
|
||
| gen := &MetricsGenerator{ | ||
| monitorService: monitorSvc, | ||
| log: log.NewHelper(log.NewStdLogger(io.Discard)), | ||
| } | ||
|
|
||
| return gen, srv.Close | ||
| } | ||
|
|
||
| func TestMetricsGenerator_taskCoreUsed_Ascend(t *testing.T) { | ||
| gen, cleanup := newTestGenerator(t, testPromHandler(t, "42.5")) | ||
| defer cleanup() | ||
|
|
||
| result, err := gen.taskCoreUsed(context.Background(), biz.AscendGPUDevice, "ns", "pod", "ctr", "pod-uuid", "dev-uuid", "host", 0) | ||
| if err != nil { | ||
| t.Fatalf("taskCoreUsed failed: %v", err) | ||
| } | ||
| if result != 42.5 { | ||
| t.Errorf("expected 42.5, got %v", result) | ||
| } | ||
| } | ||
|
|
||
| func TestMetricsGenerator_taskMemoryUsed_Ascend(t *testing.T) { | ||
| // npu_chip_info_hbm_used_memory returns MB, e.g., 8192 for 8 GB HBM | ||
| gen, cleanup := newTestGenerator(t, testPromHandler(t, "8192")) | ||
| defer cleanup() | ||
|
|
||
| result, err := gen.taskMemoryUsed(context.Background(), biz.AscendGPUDevice, "ns", "pod", "ctr", "pod-uuid", "dev-uuid", "host", 0) | ||
| if err != nil { | ||
| t.Fatalf("taskMemoryUsed failed: %v", err) | ||
| } | ||
| if result != 8192 { | ||
| t.Errorf("expected 8192 (MB), got %v", result) | ||
| } | ||
| } | ||
|
|
||
| func TestMetricsGenerator_taskCoreUsed_Ascend_EmptyResult(t *testing.T) { | ||
| gen, cleanup := newTestGenerator(t, testPromHandler(t, "")) | ||
| defer cleanup() | ||
|
|
||
| result, err := gen.taskCoreUsed(context.Background(), biz.AscendGPUDevice, "ns", "pod", "ctr", "pod-uuid", "dev-uuid", "host", 0) | ||
| if err != nil { | ||
| t.Fatalf("taskCoreUsed failed: %v", err) | ||
| } | ||
| if result != 0 { | ||
| t.Errorf("expected 0, got %v", result) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.