refactor(cli): one module per subcommand - #10
Merged
Conversation
main.rs was 2493 lines - every subcommand, the whole launch pipeline and the profile staging in one file. Pure moves, routed by item name: main.rs 274 dispatch, usage, and the Nexus commands launch.rs 481 eidos play: extender swap, mount, run, capture prepare.rs 470 staging the profile into the prefix, and reading it back tools.rs 281 eidos tool tests.rs 275 the unit tests, file-backed prereqs.rs 218 eidos prereqs nxm.rs 157 the nxm:// handler sort.rs 148 eidos sort (LOOT) install.rs 134 eidos install / import export.rs 123 eidos export games.rs 50 eidos games / init The Nexus trio (cmd_nexus, nexus_client, nexus_key_path) deliberately stays in main.rs: PR #7 rewrites exactly those functions, and moving them now would turn a pending review branch into a wall-to-wall conflict. They move once #7 lands. Verified as the fuse split was: item inventory identical (the nine additions are the test module's own fns and its Tmp helper surfacing to file level), workspace suite green, and the split binary smoke-run against the real machine.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure moves out of a 2493-line main.rs: one module per subcommand, the launch pipeline and profile staging as their own files. The Nexus command trio deliberately stays in main.rs until PR #7 lands, since #7 rewrites exactly those functions.
Item inventory identical before/after (the nine additions are the test module's contents surfacing to file level), workspace suite green, split binary smoke-run against the real machine.