WIP: Rewrite plugin in react #720
Draft
+61,720
−30,612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Test on Playground |
Contributor
✅ Code Coverage ReportPHP Coverage (PHPUnit)
✅ PHP coverage meets threshold (40%) JavaScript Coverage (Jest)
🎉 Great job maintaining/improving PHP coverage! 📊 File-level Coverage Changes (51 files)🆕 New Files
📈 Coverage Improved
📉 Coverage Decreased
ℹ️ About this report
|
aristath
force-pushed
the
ari/reactify
branch
from
7dd4357 to
73b3cf7
Compare
- Add REST API endpoints for data collectors and task evaluation - Create React task registry system with TaskProvider base class - Implement task injection service for React-registered tasks - Create InteractiveTaskProvider base class for interactive tasks - Migrate Hello_World task from PHP to React as proof of concept - Remove Hello_World from PHP Tasks_Manager registration - Integrate task injection into SuggestedTasks widget This establishes the foundation for migrating all task providers from PHP to React while maintaining a thin REST API layer for data collection and WordPress operations.
- Add taskMigrationHelper.js with common patterns and data collector IDs - Add TASK_MIGRATION.md guide for migrating PHP tasks to React - Provides reference patterns and step-by-step migration instructions
- Create SamplePageTask.js React implementation - Register task in task registry - Remove from PHP Tasks_Manager registration This follows the same pattern as Hello_World task migration.
- Create BlogDescriptionTask.js React implementation - Use WordPress REST API settings endpoint to check if tagline is empty - Register task in task registry - Remove from PHP Tasks_Manager registration
…n, SEO Plugin, Remove Inactive Plugins, Permalink Structure) - Create React implementations for 5 more tasks - Register all tasks in task registry - Remove from PHP Tasks_Manager registration This continues the gradual migration pattern established with Hello_World and Sample_Page tasks.
- Remove duplicate Search_Engine_Visibility registration - Task was already migrated to React in previous commit
…ing tasks to React
…ng from PHP Tasks_Manager
…loaded Options tasks to React
…pdate Term Description tasks to React
- Convert all task providers from constructor-based config to static properties - Update base classes (TaskProvider, InteractiveTaskProvider) to read from static properties - Update task registry to accept classes instead of instances - Update task injection service to support multi-task providers with getTasksToInject() - Add isMultiTask static property and getTasksToInject() method for multi-task providers - Remove singleton instances from all 30 task files - Export classes directly instead of instances - Update task registration to import and register classes - Add support for target_taxonomy in getTaskId() for multi-task providers - Fix nested ternary expression linting issue This makes it easier to add new task providers by simply defining static properties without needing constructors.
- Update taskRegistry to listen for 'prpl.tasks.register' action - Add task lifecycle handling: evaluate, check existence, create post, render - Refactor SuggestedTasks widget to support streaming tasks - Add sorted insertion by priority for streaming tasks - Update BlogDescriptionTask to self-register as example - Remove bulk task fetching, tasks now stream in as they register
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewriting the plugin, from PHP + Vanilla-JS to React.
Playground link