Skip to content

Fix: .md URLs with non-ASCII slugs (å/ä/ö) never resolve #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TBarregren wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: .md URLs with non-ASCII slugs (å/ä/ö) never resolve #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Router/RewriteHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ public function prevent_markdown_redirect($redirect_url, $requested_url) {
* @return void
*/
public function parse_markdown_url(\WP $wp): void {
$request_uri = isset($_SERVER['REQUEST_URI']) ? sanitize_text_field(wp_unslash($_SERVER['REQUEST_URI'])) : '';
// Use esc_url_raw() rather than sanitize_text_field() here: the latter
// strips every percent-encoded octet (%[a-f0-9]{2}), which destroys
// non-ASCII slugs (e.g. å/ä/ö, encoded as %c3%a5/%c3%a4/%c3%b6) and makes
// the post lookup below fail. esc_url_raw() preserves the encoding.
$request_uri = isset($_SERVER['REQUEST_URI']) ? esc_url_raw(wp_unslash($_SERVER['REQUEST_URI'])) : '';
$path = wp_parse_url($request_uri, PHP_URL_PATH);
if ($path === false || $path === null) {
return;
Expand Down Expand Up @@ -276,7 +280,9 @@ public function handle_markdown_request(): void {
return;
}

$request_uri = isset($_SERVER['REQUEST_URI']) ? sanitize_text_field(wp_unslash($_SERVER['REQUEST_URI'])) : '';
// esc_url_raw() preserves percent-encoded octets so the trailing-slash
// redirect works for non-ASCII slugs (see parse_markdown_url()).
$request_uri = isset($_SERVER['REQUEST_URI']) ? esc_url_raw(wp_unslash($_SERVER['REQUEST_URI'])) : '';

// Enforce lowercase .md extension — reject wrong case and let WordPress 404.
if (
Expand Down