Repository navigation
Week 3 - #4
Week 3#4
Conversation
…-patch-1 Ignore: Adding the action to week-3 branch
|
Hi Emma! I was able to download the package and the unit tests all ran :) I see you're still updating stuff for the vignette so looking forward to seeing the final report and your presentation! |
davidcleve
left a comment
davidcleve
left a comment
There was a problem hiding this comment.
Hi Emma,
Unfortunately I couldn't see your functions, unit tests, and app code in this pull request. I am not entirely sure what went wrong, but it might be related to your numerous commits.
I gave feedback on the files and code I did see :) You can find it in my comments.
The installation of your package worked fine. The way I see it, your package only includes two functions as of now, so I am curious where it will go! Also curious about your vignette once it includes some more info!
Best,
David
| @@ -0,0 +1,50 @@ | |||
| # Workflow derived from https://github.com/r-lib/actions/tree/v2/examples | |||
| # Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help | |||
There was a problem hiding this comment.
Is there a reason that you have two .github folders including the CI code? :)
| # Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help | ||
| on: | ||
| push: | ||
| branches: [main, master] |
There was a problem hiding this comment.
If you specify push: branches: [main, master], the CI checks won't run when you push to subbranches (e.g. week-3). So if you always want the checks to run, just include push:.
| @@ -1,4 +1,6 @@ | |||
| This package attempt to provide an intuitive visualization of whether | |||
There was a problem hiding this comment.
Why do you have two README files? :)
There was a problem hiding this comment.
And I'm missing the NAMESPACE, but this might also be related to the several commits you made.
| @@ -1,51 +0,0 @@ | |||
| # | |||
There was a problem hiding this comment.
I think since you committed several times, I can't see your full code here. Or maybe there is another reason.
But it looks like I can't review your functions and app code since they don't exist in this pull-request. There aren't any unit tests either for me to see.
But downloading your package worked perfectly and your two functions simulate_logistic() and
data_log_plot() ran!
| The first step after installing the package is to run the function `run.plotter()`. | ||
|
|
||
| ```{r, eval=F} | ||
| run.plotter() |
There was a problem hiding this comment.
This one didn't work for me yet, but that might be because the function and app code don't exist yet.
| knitr, | ||
| quarto, | ||
| testthat, | ||
| usethis |
There was a problem hiding this comment.
I believe that knitr, quarto, testthat, and usethis belong in the Suggests section since they are not necessary to run your functions and app. You only need them for your vignette and unit tests.
3 participants
No description provided.