Fix jsonLdService method call in ApRendererService#35
Conversation
… activities attachLdSignature() called this.jsonLdService.signRsaSignature2017(...) directly, but JsonLdService only exposes use(), which returns the JsonLd instance that actually implements signRsaSignature2017. This caused "this.jsonLdService.signRsaSignature2017 is not a function" when signing activities delivered to relays. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JzqoS7cjvodFiWW6qZxyXL
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughIn ChangesLD Signature Service Call Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Updated the
jsonLdService.signRsaSignature2017()method call to use the.use()accessor pattern in the ActivityPub renderer service.Why
The
jsonLdServiceappears to require using the.use()method to access its functionality, likely due to a service initialization or dependency injection pattern. This change ensures the method is called correctly on the service instance.Additional info
https://claude.ai/code/session_01JzqoS7cjvodFiWW6qZxyXL
Summary by CodeRabbit