Skip to content

Fix jsonLdService method call in ApRendererService#35

Merged
PrivateGER merged 1 commit into
developfrom
claude/eloquent-franklin-jmw7ci
Jun 21, 2026
Merged

Fix jsonLdService method call in ApRendererService#35
PrivateGER merged 1 commit into
developfrom
claude/eloquent-franklin-jmw7ci

Conversation

@PrivateGER

@PrivateGER PrivateGER commented Jun 21, 2026

Copy link
Copy Markdown
Owner

What

Updated the jsonLdService.signRsaSignature2017() method call to use the .use() accessor pattern in the ActivityPub renderer service.

Why

The jsonLdService appears to require using the .use() method to access its functionality, likely due to a service initialization or dependency injection pattern. This change ensures the method is called correctly on the service instance.

Additional info

  • Minimal change affecting only the ActivityPub signature generation flow
  • No functional behavior change, only correcting the API usage pattern

https://claude.ai/code/session_01JzqoS7cjvodFiWW6qZxyXL

Summary by CodeRabbit

  • Refactor
    • Internal optimization to signature handling in ActivityPub processing. No user-visible changes.

… activities

attachLdSignature() called this.jsonLdService.signRsaSignature2017(...)
directly, but JsonLdService only exposes use(), which returns the JsonLd
instance that actually implements signRsaSignature2017. This caused
"this.jsonLdService.signRsaSignature2017 is not a function" when signing
activities delivered to relays.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JzqoS7cjvodFiWW6qZxyXL
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 84db2462-73b8-4c18-8270-7c9b867d8907

📥 Commits

Reviewing files that changed from the base of the PR and between cd1bcd4 and d53fb46.

📒 Files selected for processing (1)
  • packages/backend/src/core/activitypub/ApRendererService.ts

Walkthrough

In ApRendererService.attachLdSignature, the RSA signature attachment call is changed from this.jsonLdService.signRsaSignature2017(...) to this.jsonLdService.use().signRsaSignature2017(...), inserting a .use() accessor before invoking the signing method. No other logic is modified.

Changes

LD Signature Service Call Fix

Layer / File(s) Summary
Fix jsonLdService.use() signing call
packages/backend/src/core/activitypub/ApRendererService.ts
Replaces the direct jsonLdService.signRsaSignature2017(...) call with jsonLdService.use().signRsaSignature2017(...), changing how the signing service instance is obtained before applying the LD signature.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: fixing the jsonLdService method call to use the proper accessor pattern.
Description check ✅ Passed The description includes all key template sections (What, Why, Additional info) with substantive content explaining the fix and its rationale.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/eloquent-franklin-jmw7ci

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PrivateGER PrivateGER merged commit bcde1f2 into develop Jun 21, 2026
5 checks passed
@PrivateGER PrivateGER deleted the claude/eloquent-franklin-jmw7ci branch June 21, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants