fix(v1): allow concurrent borrowed runtime environments - #2418
Draft
parkerpettit wants to merge 1 commit into
Draft
fix(v1): allow concurrent borrowed runtime environments#2418parkerpettit wants to merge 1 commit into
parkerpettit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Harbor runtime environment change serialized every borrowed rollout through one lock. That prevents two agents from running concurrently in the same box, even when the runtime has no mutable network policy.
Runtime.with_env()keeps the physical sandbox handles shared while each rollout gets its own process environment.Tests
uv run --project third_party/verifiers pytest third_party/verifiers/tests/v1/test_borrowed_runtime_env.py -quv run --project third_party/verifiers ruff check third_party/verifiers/verifiers/v1/rollout.py third_party/verifiers/verifiers/v1/runtimes/base.py third_party/verifiers/tests/v1/test_borrowed_runtime_env.pyuv run --project third_party/verifiers ruff format --check third_party/verifiers/verifiers/v1/rollout.py third_party/verifiers/verifiers/v1/runtimes/base.py third_party/verifiers/tests/v1/test_borrowed_runtime_env.pyNote
Fix
Rollout.opento allow concurrent borrowed runtime environmentsRuntime.with_envin base.py to create a shallow-copied runtime view with an isolatedenvwhile sharing the underlying sandboxRollout.opennow stores the original borrowed runtime in_borrowed_runtime; unrestricted borrowers callwith_envper rollout instead of taking the borrow lock, so concurrent rollouts get independent envsborrow_lockand swapruntime.envserially, preserving the owner's env across teardownRollout.failchecks_borrowed_runtime.stoppedto correctly detect teardown of the originally borrowed runtime even whenself.runtimehas been replaced by a viewborrow_lockinRollout.open; concurrent rollouts now run in parallel where they were previously serializedMacroscope summarized f6e3322.