Skip to content

fix(coding-agent): keep Down Arrow in unfinished prompts - #1226

Merged
snimu merged 1 commit into
mainfrom
eng-5147
Aug 11, 2026
Merged

fix(coding-agent): keep Down Arrow in unfinished prompts#1226
snimu merged 1 commit into
mainfrom
eng-5147

Conversation

@snimu

@snimu snimu commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep Down Arrow in the chat prompt until the cursor reaches the end before focusing the Agents View entry below it
  • replace the old last-visual-line interception with an exact prompt-end boundary
  • remove the now-unused protected visual-line wrapper from the base editor

Testing

  • npm run check

Linear: ENG-5147


Note

Low Risk
Localized interactive prompt keybinding change with no auth, data, or API impact; behavior is covered by regression tests referenced in the PR.

Overview
Down Arrow in the chat prompt no longer jumps to the Agents View entry (subagent summary below the prompt) until the cursor is at the end of the prompt text on the last line.

CustomEditor now gates onMoveBelowPrompt on a new isCursorAtEnd() check instead of only being on the last visual (wrapped) line. The first Down press still moves within the editor (e.g. to line end); focus moves below only when the cursor is already at the true end. Empty prompts behave as before: Down can focus below immediately.

The unused isCursorOnLastVisualLine() bridge on the base Editor in pi-tui was removed.

Reviewed by Cursor Bugbot for commit 55ae068. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix Down Arrow in CustomEditor to stay in nonempty prompts until cursor reaches end

Previously, pressing Down Arrow on any wrapped last visual line would immediately move focus to the Agents View. Now, CustomEditor.handleInput only calls onMoveBelowPrompt() when the cursor is at the end of the last line, using a new isCursorAtEnd() helper. The old isCursorOnLastVisualLine() method on Editor is removed.

Macroscope summarized 55ae068.

@snimu
snimu merged commit 795a21d into main Aug 11, 2026
17 checks passed
@snimu
snimu deleted the eng-5147 branch August 11, 2026 17:12
@snimu snimu mentioned this pull request Aug 11, 2026
9 tasks
sethkarten pushed a commit that referenced this pull request Aug 11, 2026
Patch release. Bug fixes, small UX additions behind existing surfaces, and a
dependency consolidation; no breaking changes, per the no-major-releases
policy.

Contents since v0.7.1:
- #838 in-place queue editing (Alt+Up/Alt+Down browse, Enter/Alt+Enter apply)
  and queue preservation on interrupt
- #850/#851/#852 worker lifecycle truthfulness, timed-out stop finalization,
  and stale-registration self-heal (the "Session worker is not connected"
  family)
- #1226 Down Arrow stays in a nonempty prompt until the cursor reaches the end
- #767 independent expand/collapse for tool calls, a2a messages, and thinking
- #1135 agents view keeps expansion state when leaving and returning
- #647 login URL copy action
- #521 privacy-safe agent analytics with disclosure and opt-out
- #846 Homebrew ownership preserved on self-update
- #772 sent a2a messages show only message text when expanded
- #632 consolidated dependency updates (undici 7.29, biome 2.5.5, marked 18,
  typescript 7 dev-only, typebox 1.3, aws-sdk bedrock, vitest 4.1.10, et al.)
- #1132 stale Gemini test model update (test-only)

Missing changelog entries for #838/#850/#851/#852 are added under 0.7.2.

Lockstep bump across the root package and the four published packages;
example and private workspaces untouched. Lockfile updated surgically
(version fields and inter-package ranges only).
0oAstro pushed a commit to 0oAstro/fulcrum that referenced this pull request Aug 11, 2026
0oAstro pushed a commit to 0oAstro/fulcrum that referenced this pull request Aug 11, 2026
Patch release. Bug fixes, small UX additions behind existing surfaces, and a
dependency consolidation; no breaking changes, per the no-major-releases
policy.

Contents since v0.7.1:
- PrimeIntellect-ai#838 in-place queue editing (Alt+Up/Alt+Down browse, Enter/Alt+Enter apply)
  and queue preservation on interrupt
- PrimeIntellect-ai#850/PrimeIntellect-ai#851/PrimeIntellect-ai#852 worker lifecycle truthfulness, timed-out stop finalization,
  and stale-registration self-heal (the "Session worker is not connected"
  family)
- PrimeIntellect-ai#1226 Down Arrow stays in a nonempty prompt until the cursor reaches the end
- PrimeIntellect-ai#767 independent expand/collapse for tool calls, a2a messages, and thinking
- PrimeIntellect-ai#1135 agents view keeps expansion state when leaving and returning
- PrimeIntellect-ai#647 login URL copy action
- PrimeIntellect-ai#521 privacy-safe agent analytics with disclosure and opt-out
- PrimeIntellect-ai#846 Homebrew ownership preserved on self-update
- PrimeIntellect-ai#772 sent a2a messages show only message text when expanded
- PrimeIntellect-ai#632 consolidated dependency updates (undici 7.29, biome 2.5.5, marked 18,
  typescript 7 dev-only, typebox 1.3, aws-sdk bedrock, vitest 4.1.10, et al.)
- PrimeIntellect-ai#1132 stale Gemini test model update (test-only)

Missing changelog entries for PrimeIntellect-ai#838/PrimeIntellect-ai#850/PrimeIntellect-ai#851/PrimeIntellect-ai#852 are added under 0.7.2.

Lockstep bump across the root package and the four published packages;
example and private workspaces untouched. Lockfile updated surgically
(version fields and inter-package ranges only).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants