fix(coding-agent): acknowledge prompts queued during streaming - #1185
Open
nnunley wants to merge 2 commits into
Open
fix(coding-agent): acknowledge prompts queued during streaming#1185nnunley wants to merge 2 commits into
nnunley wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The acknowledgement is emitted by the interactive client after admission, so it does not depend on the active model producing another token. #1181 tracks the broader received/applied/discarded lifecycle across all clients.
Testing
npx tsx ../../node_modules/vitest/dist/cli.js --run test/interactive-mode-status.test.ts(154 tests passed)npm run checkNote
Acknowledge prompts queued during streaming in interactive mode
When a prompt is submitted while the agent is streaming,
InteractiveMode.setupEditorSubmitHandlernow immediately shows a status message confirming the submission was received and queued. The message varies bystreamingBehavior:'steer'reports queuing until the next model boundary;'followUp'reports queuing until the current run finishes.Macroscope summarized 1a298f9.