Conversation
Switched to external ci actions
GitHub add issue to project workflow
The 9.0.x branch no longer exists. PHPStan coverage for PS 9.x is already provided by the phpstan job targeting 9.1.x and develop. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Drop the 8.1.7 target to match the project-wide module cleanup Epic which standardizes native modules on PS 8.2+: - php.yml: phpstan-74 matrix now runs against 8.2.x only (PHP 7.4/8.1) - ps_versions_compliancy min bumped to 8.2.0 - remove the now-unreferenced phpstan-8.1.7.neon config - remove the orphaned phpstan-9.0.x.neon config (no longer in the matrix) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop dead PHPStan configs no longer referenced by the CI matrix (targeting PrestaShop versions < 8.2): - phpstan-1.7.7.neon - phpstan-1.7.8.neon - phpstan-8.0.neon - phpstan-latest.neon Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…Epic #41648) renderCartPage(): the method definition used a different case (renderCartpage) than its call site at run() (renderCartPage). PHP method names are case-insensitive so it worked at runtime, but the PHPStan 0.12 job flagged the definition as unused. Align the casing and drop its ignoreErrors entry. The remaining ignoreErrors are genuine framework/structural limitations, now documented inline in the neon configs: - Cookie magic __get/__set properties (ga_admin_order / ga_admin_refund) - parent::uninstall() called through a closure rebound via Closure::bindTo() - HookActionValidateOrder::$module: HookInterface mandates the (Ps_Googleanalytics $module, Context) constructor signature, so $module must be stored even though this hook never reads it back Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…9.0.3 - php-linter: add missing intermediate syntax checks (7.3, 8.1, 8.2, 8.3, 8.4) - phpstan-74: lower floor to PHP 7.2 (real minimum for PS 8.2.x) - phpstan: add PrestaShop 9.0.3 (tag, the 9.0.x branch no longer exists) + neon config Part of PrestaShop/PrestaShop#41648 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- phpstan-9.0.3.neon was missing the ignoreErrors block (framework/structural limitations), so the PS 9.0.3 jobs reported them as errors; align it with the 9.1.x/develop configs - restore the phpstan-74 floor to PHP 7.4: the module's dev tooling (prestashop/php-dev-tools) pulls a dependency requiring PHP >= 7.4, so composer install fails on 7.2 (php-linter still covers 7.2 at the syntax level) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
PrestaShop 9.0.x supports PHP 8.1 up to 8.4 only, so the cross-product matrix was generating an invalid 9.0.3 x 8.5 combination. Switch to an explicit include list so each PrestaShop version tests its proper PHP floor and ceiling (9.0.3: 8.1/8.4, 9.1.x and develop: 8.1/8.5). Also make the "Prepare PHP env" step name reflect the actual matrix version. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CI: align PHPStan on PS 8.2+, refresh neon configs and fix renderCartPage error
Hlavtox
requested changes
Jun 19, 2026
Hlavtox
left a comment
Hlavtox
left a comment
Contributor
There was a problem hiding this comment.
Why do we need a release if no public facing code was changed?
jolelievre
reviewed
Jun 19, 2026
Co-authored-by: Jonathan Lelievre <jonathan.lelievre@prestashop.com>
Contributor
Author
|
hey @Hlavtox, no public code change indeed, but the PS compatibility range changed (min raised from 8.1.0 to 8.2.0). dropping a supported version is a BC break in our module versioning policy, so it needs a major release (v6.0.0), otherwise merchants still on 8.1 would be offered an incompatible update. it's part of the 8.2+ alignment epic #41648. |
Contributor
|
@mattgoud Yes yes I know, but it can only stay on the dev branch no? CI will work, and we will do a release when it's actually needed. |
Contributor
Author
Contributor
|
@mattgoud You know, if there are no changes, it's just noise, and people wondering what is changed in the module. :-) |
Contributor
Author
Hello @Hlavtox, talked it over with the team this morning. Fair point on the noise 👍 , but we're about to cut 9.0.2-BETA and the team wants ps_googleanalytics on clean foundations for it. so we'll go ahead with the v6.0.0 release. |
github-project-automation
Bot
moved this from Ready for review
to Merged
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
devintomasterto release v6.0.0.Includes the PrestaShop 8.2+ CI/compatibility alignment (Epic PrestaShop/PrestaShop#41648) and the module version bump to 6.0.0 (minimum PS version raised to 8.2.0 → major / BC break).
After merge, the push to⚠️ release-drafter proposes a patch tag (
mastertriggers the build workflow which creates a release draft with the module zip attached.v$NEXT_PATCH_VERSION) — the draft must be published as v6.0.0.