Qualify the shop restriction in the product reviews count - #62
Open
boo-code wants to merge 1 commit into
Open
Conversation
|
Hello @boo-code! This is your first pull request on dashactivity repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
id_shop. On a shop whoseproducttable still carries a legacyid_shopcolumn, that column exists on two tables in the query and MySQL answers#1052 - Column 'id_shop' in where clause is ambiguous, so the dashboard activity block fails. Qualifying the restriction with theproduct_shopalias, which is the table the value is meant to be read from, removes the ambiguity.How to test
The generated query is:
Reproduced by standing in for the legacy schema with a copy of
productcarrying anid_shopcolumn, on MySQL 8.4:A shop whose
producttable has noid_shopnever sees the error, because the bare name then resolves toproduct_shop.id_shopon its own. That is also why the change is a no-op there: it names the column the query was already resolving to.Scope
Only this query is changed. The other unqualified
Shop::addSqlRestriction()calls in the file read from a single table -connections,cart,customer- so no ambiguity is possible, and the one at line 249 joinsorderswithorder_state, which has noid_shopcolumn.