Refactor: Optimize code and improve safety checks#99
Open
berhili098 wants to merge 3 commits intoPramodJoshi:masterfrom
Open
Refactor: Optimize code and improve safety checks#99berhili098 wants to merge 3 commits intoPramodJoshi:masterfrom
berhili098 wants to merge 3 commits intoPramodJoshi:masterfrom
Conversation
- Added `flutter_lints` dependency to `pubspec.yaml` for better code quality checks. - Enhanced `shouldRepaint` method in `CustomBorderPaint` to consider thickness, radius, and gradient changes. - Refactored `RowToColumn` widget to simplify layout logic and ensure proper alignment defaults. - Added assertions in `Utils` class to validate input parameters for better error handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several important changes to improve the functionality and maintainability of the codebase. The changes range from updates to dependencies to refinements in custom painting logic and widget layout handling.
Dependency update:
example/pubspec.yaml: Addedflutter_lintsversion^3.0.1todev_dependenciesto ensure code quality and standardization.Custom painting logic:
lib/src/custom_border_paint.dart: Modified theshouldRepaintmethod inCustomBorderPaintto comparethickness,radius, andgradientproperties for determining if a repaint is necessary.Widget layout handling:
lib/src/row_to_column.dart: Refactored thebuildmethod inRowToColumnto improve readability and maintainability by introducing a local variableisRowand a finallayoutwidget.Utility method improvement:
lib/src/utils.dart: Added assertions and refined the logic in thecalculateWidthmethod to handlecustomWidthsmore robustly and ensure valid inputs.