fix: stop telling the per-task pi harness to use a TaskUpdate tool it never gets#982
Draft
posthog[bot] wants to merge 1 commit into
Draft
fix: stop telling the per-task pi harness to use a TaskUpdate tool it never gets#982posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
…r gets Orchestrator per-task sessions on the pi harness (runPiTask) never register TaskCreate/TaskUpdate — only the linear harnesses (pi index.ts, anthropic preset) do — but every session got the same universal commandment telling it to "drive the work with TaskUpdate." Multiple task types (identify, capture, review) repeatedly remarked that a task-management tool referenced by their instructions was unavailable. getWizardCommandments() now takes an includeTaskTracking flag; the per-task harness opts out. Generated-By: PostHog Code Task-Id: d5b36c7d-a77f-416e-a17d-db79843ab95a
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
posthog
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multiple
integration-v2task types (identify, capture, review) remarked in production that a task-management tool their instructions referenced was unavailable, at ~9 occurrences across the last cycle's fleet. Verified against the code:runPiTask(src/lib/agent/runner/harness/pi/task.ts), the per-task orchestrator session on the pi harness, never registersTaskCreate/TaskUpdate— only the linear harnesses (pi/index.ts, the anthropic preset inagent-interface.ts) wire uppi/tasks.ts. Yet every session, including the leaner per-task one, got the same universal wizard commandment: "Create tasks... Drive the work with TaskUpdate." Agents correctly noticed the contradiction and reported it as lost turns.Refs #588, which already flagged
commandments.ts's shared task-list commandment as needing harness-aware guidance.Changes
getWizardCommandments()now takes an{ includeTaskTracking?: boolean }option; the two task-list-specific commandments move to a separateTASK_TRACKING_COMMANDMENTSblock, included by default.runPiTask(pi/task.ts) now callsgetWizardCommandments({ includeTaskTracking: false })since it never grants the tool.pi/index.ts,agent-interface.ts) are unchanged — they keep the default (true) and still get the full commandment set.Test plan
npx vitest run— 113 files / 1541 tests pass (updated thecommandmentssnapshot for the reordering)pnpm build— succeeds, including the warlock smoke testpnpm fix— no lint/format changes neededCreated with PostHog Code