Repository navigation
fix(warehouse-sources): upgrade pyarrow to 26.0.1, drop brotli guard - #136823
Conversation
|
😎 Merged successfully - details. |
There was a problem hiding this comment.
Reviewed fd7402a against master, including the PR description and existing discussion, dependency and lockfile changes, removal of the Brotli guards in Delta/object storage, AWS Cost and Usage Report and autoresearch, and the associated test changes. Checked correctness, security, data safety, performance, test coverage, overengineering and scope creep. The Arrow 26.0.1 dependency manifest pins Brotli 1.2.1. Tests, builds and linters were not run, as requested.
No issues found.
— Robo Bill v2 (gpt-6.1-sol, high reasoning)
|
Hey @Gilbert09! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
|
Risk: No findings This increment adds one test-only change (an async access-denied assertion in the object-store tests) and bumps modal 1.5.5 → 1.6.4 in pyproject.toml with a matching uv.lock pin. No security-relevant regression: modal 1.6.x's only security-adjacent change hardens block_network, and both repo call sites set it without ports. Sentinel reviewed |
There was a problem hiding this comment.
Not approved — this change needs a human reviewer.
Re-adding the stamphog label gives the same result unless the changed files change.
stamphog declined to auto-review this pull request because two gates failed. The deny-list gate matched the deps_toolchain category, most likely because pyproject.toml and uv.lock change the pyarrow dependency. The tier gate classified the change as T2-never, so it requires a human reviewer regardless of its size (195 lines across 13 files).
The author should ask a human reviewer to look at it. Since the dependency bump touches a security-relevant library, that reviewer should probably be someone who owns dependencies or security.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✗ | matches: deps_toolchain |
| every_file_attested | ✓ | not a bot PR |
| size | ✓ | 67L, 8F substantive, 1 binary; 195L/13F incl. docs/generated/snapshots — within ceiling |
| tier | ✗ | classified as T2-never: T2-never (195L, 13F, single-area, fix) |
| stamphog 2.9.0 | .stamphog/policy.yml @ unknown · reviewed head fd7402a |
|
✅ Security review complete — 1 finding posted as a review, in 6 min. Add the |
🤖 CI report
|
| App | JS | CSS |
|---|---|---|
| debug | 1067.4 KB | 225.2 KB |
| explain-chart | 1352.7 KB | 225.2 KB |
| action | 994.8 KB | 225.2 KB |
| action-list | 1058.5 KB | 225.2 KB |
| cohort | 993.8 KB | 225.2 KB |
| cohort-list | 1057.5 KB | 225.2 KB |
| email-template | 993.6 KB | 225.2 KB |
| error-details | 998.7 KB | 225.2 KB |
| error-issue | 995.7 KB | 225.2 KB |
| error-issue-list | 1059.7 KB | 225.2 KB |
| experiment | 1055.6 KB | 225.2 KB |
| experiment-list | 1059.3 KB | 225.2 KB |
| experiment-results | 1057.7 KB | 225.2 KB |
| feature-flag | 1057.9 KB | 225.2 KB |
| feature-flag-list | 1061.6 KB | 225.2 KB |
| feature-flag-testing | 997.0 KB | 225.2 KB |
| inline-scan | 994.3 KB | 225.2 KB |
| insight-actors | 1057.0 KB | 225.2 KB |
| llm-costs | 1054.3 KB | 225.2 KB |
| session-recording | 996.0 KB | 225.2 KB |
| survey | 995.4 KB | 225.2 KB |
| survey-global-stats | 1054.3 KB | 225.2 KB |
| survey-list | 1059.2 KB | 225.2 KB |
| survey-stats | 1054.3 KB | 225.2 KB |
| trace-span | 994.2 KB | 225.2 KB |
| trace-span-list | 1058.8 KB | 225.2 KB |
| vision-observation-list | 1057.6 KB | 225.2 KB |
| workflow | 994.1 KB | 225.2 KB |
| workflow-list | 1057.9 KB | 225.2 KB |
| workflow-setup-status | 993.8 KB | 225.2 KB |
| query-results | 1322.0 KB | 225.2 KB |
| render-ui | 1429.0 KB | 225.2 KB |
| visual-review-snapshots | 998.7 KB | 225.2 KB |
| workflow-data-suggestions | 996.5 KB | 225.2 KB |
| workflow-sending-rules | 995.1 KB | 225.2 KB |
⚠️ Playwright — 1 flaky
🎭 Playwright report · View test results →
- a secret header entered in the workflow builder is stored encrypted and read back masked (chromium)
These issues are not necessarily caused by your changes.
Annoyed by this section? Help fix flakies and failures and it will go green!
|
/trunk merge |
Deploy status
This table shows the |
Problem
Changes
pandasextra.How did you test this code?
Test rationale: no new test, because no PostHog code handles Brotli now.
BrotliDecoderVersionin the Linux x86_64 wheels returns 1.1.0 for 23.0.1 and 1.2.1 for 26.0.1.Release status
Docs update
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, Opus 5.5 (
claude-opus-5-5)Skills:
/writing-tests,/writing-pr-descriptionsSecurity review: needed
More context for AI agents
uv.lockkeeps only the pyarrow block; the box's registry filter reorders a torch entry otherwise..brrefusal inposthog/hogql/database/s3_table.py(fix(warehouse-sources): read warehouse files in chdb with an explicit codec #123070) stays; it covers ClickHouse's Brotli, not pyarrow's.uv.lockpyarrow block,delta.pyiter_tables.View this session in Talyn