fix(llma): use distinct_id from outer context if not provided#449
Open
ethanporcaro wants to merge 2 commits intoPostHog:masterfrom
Open
fix(llma): use distinct_id from outer context if not provided#449ethanporcaro wants to merge 2 commits intoPostHog:masterfrom
ethanporcaro wants to merge 2 commits intoPostHog:masterfrom
Conversation
Author
|
Some of these failed tests are passing on my machine. Do the tests set an outer distinct_id? |
Author
|
Nevermind, I realize I was running them incorrectly. I think I found the issue and will push a commit soon |
Author
|
Should be good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #443
Right now, the LLM analytics wrappers accept a
posthog_distinct_idparameter, but override any existing distinct_id, even if the parameter is None.The utility functions pass
However, if posthog_distinct_id is None (default) it will default to the
posthog_trace_id, even if an ID exists on the outer context.This PR modifies the logic to do the following:
distinct_idis passed by parameter, it is used inidentify_contexttrace_id.ph_client.capturewithout the distinct_id parameter, so that it uses whatever was set from the above steps.Let me know if any changes are needed or if I should implement this differently.