feat(flags): add semver targeting to local evaluation#86
Closed
feat(flags): add semver targeting to local evaluation#86
Conversation
Contributor
posthog-elixir Compliance ReportDate: 2026-03-02 22:09:31 UTC ✅ All Tests Passed!29/29 tests passed Capture Tests✅ 29/29 tests passed View Details
|
rafaeelaudibert
requested changes
Mar 2, 2026
Member
rafaeelaudibert
left a comment
There was a problem hiding this comment.
@dmarticus Ahn, I don't think there's local evaluation in Elixir yet? So... this is moot?
You're literally defining the module, but it's not connected in any way or form to the actual SDK. Local evaluation in Elixir is very tricky because we can make it work very well with the Erlang machine, but we haven't built that yet
Contributor
Author
|
ope, didn't realize. Will nuke. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semver_eq,semver_neq,semver_gt,semver_gte,semver_lt,semver_ltesemver_tilde(~1.2.3),semver_caret(^1.2.3),semver_wildcard(1.2.*)v/Vprefix stripping (e.g., "v1.2.3" → {1, 2, 3})lib/posthog/feature_flags/property_matcher.ex) that also includes equality, string, numeric, and date operators for complete local flag evaluation supportThis aligns the Elixir SDK with the semver targeting feature available in other PostHog SDKs:
user_blast_radiusposthog#44596Test plan
mix test test/posthog/feature_flags/property_matcher_test.exs)v/Vprefix handling~1.2.3matches>=1.2.3 <1.3.0^1.2.3matches>=1.2.3 <2.0.0, with special handling for 0.x versions1.2.*matches>=1.2.0 <1.3.0InconclusiveMatchErrorInconclusiveMatchErrorInconclusiveMatchErrorfalsemix test)