fix: support Slack workspaces in loop notifications#3721
Merged
Conversation
Generated-By: PostHog Code Task-Id: e2b452a2-5abd-4732-82bd-2e380f30a465
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: e2b452a2-5abd-4732-82bd-2e380f30a465
MattPua
marked this pull request as ready for review
July 22, 2026 16:44
charlesvien
approved these changes
Jul 22, 2026
Generated-By: PostHog Code Task-Id: e2b452a2-5abd-4732-82bd-2e380f30a465
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/settings/sections/SlackInboxNotificationsSettings.tsx:68
**Team Default Uses First Workspace**
With multiple Slack integrations, this always loads the team default channel from `slackIntegrations[0]`. If the saved default belongs to another workspace, the picker queries the wrong channel list and offers no way to select the correct workspace, so the displayed workspace and persisted channel can disagree.
Reviews (1): Last reviewed commit: "refactor: extract Slack workspace channe..." | Re-trigger Greptile |
Generated-By: PostHog Code Task-Id: e2b452a2-5abd-4732-82bd-2e380f30a465
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Loop Slack destinations searched only the first connected workspace, making channels in other connected workspaces unavailable.
Changes
Before:

After
CleanShot.2026-07-22.at.12.37.08.mp4
How did you test this?
pnpm --filter @posthog/ui typecheckpnpm exec vitest run src/features/settings/components/SlackChannelCombobox.test.tsxRoot
pnpm typecheckremains blocked by unrelated existing@posthog/webmodule-resolution errors for@posthog/agentand@posthog/host-trpc.Automatic notifications
Created with PostHog Code