Skip to content

Show custom image security failure reasons#3708

Merged
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/show-image-security-failure-reason
Jul 22, 2026
Merged

Show custom image security failure reasons#3708
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/show-image-security-failure-reason

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Problem

Custom image builder failures only expose their cause through an undiscoverable native hover title.

Why: People need to understand whether a security scan rejected their image spec or the scan itself failed before retrying or changing the spec.

Changes

Add an accessible info button beside failed image builds. Its tooltip displays the structured security finding returned by the scan, or the underlying build error when the scan did not produce a valid verdict.

@trunk-io

trunk-io Bot commented Jul 22, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 417741d.

@tatoalo tatoalo self-assigned this Jul 22, 2026
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 22, 2026
Generated-By: PostHog Code
Task-Id: 2d74bf08-f149-412d-9458-e13121767aad
@tatoalo
tatoalo force-pushed the posthog-code/show-image-security-failure-reason branch from c83f3c5 to 417741d Compare July 22, 2026 13:58
@tatoalo
tatoalo marked this pull request as ready for review July 22, 2026 13:59
@tatoalo
tatoalo enabled auto-merge (squash) July 22, 2026 13:59
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "chore: show custom image build failure r..." | Re-trigger Greptile

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, self-contained UI change surfacing an existing failure-detail string in an accessible tooltip; no risky territory touched and author has strong familiarity with this file.

  • Author wrote 100% of the modified lines and has 6 merged PRs in these paths (familiarity STRONG).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 37L, 1F substantive — within ceiling
tier T1-agent / T1b-small (37L, 1F, single-area, unknown)
stamphog 2.0.0b3 .stamphog/policy.yml @ 79e156c · reviewed head 417741d

@trunk-io
trunk-io Bot merged commit 2014b24 into main Jul 22, 2026
42 of 43 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/show-image-security-failure-reason branch July 22, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant