fix(auth): Revert OAuth scopes to wildcard to fix prod login#3668
Merged
Conversation
|
😎 This pull request was merged. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Login against US prod is broken: /oauth/authorize redirects back with error=invalid_scope. #3411 switched the OAuth request from "" to an explicit scope list including the privileged llm_gateway:read, but the prod OAuth app rows have no seeded scope ceiling. The server only grandfathers "" under an empty ceiling and rejects any privileged scope, so every login fails. The same PR bumped OAUTH_SCOPE_VERSION, which force-logs-out existing sessions into that broken flow, so any build with #3411 locks users out entirely. v0.57.262 is tagged with this and must not ship until this lands.
Changes
Revert OAUTH_SCOPES to [""] and OAUTH_SCOPE_VERSION to 5, restoring the exact behavior of v0.57.257. Existing "" tokens keep working with no forced re-auth. The explicit list can re-land once the US and EU OAuthApplication ceilings are seeded with ["@default", "llm_gateway:read"].
How did you test this?
Automatic notifications