chore(stamphog): sync engine from upstream and raise line ceiling to 1200#3667
Merged
Conversation
|
😎 This pull request was merged. |
Contributor
|
Reviews (1): Last reviewed commit: "raise stamphog line ceiling to 1200" | Re-trigger Greptile |
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stamphog's vendored engine had drifted ~2 months behind
PostHog/posthog'stools/pr-approval-agent(local copy was pinned at May'sc456bb59b67plus two cherry-picks), and the 1000-line auto-review ceiling was rejecting PRs we want reviewed.Changes
Re-vendors the engine at upstream
b49088aa600, following the sync protocol upstream documents (re-copy, re-apply documented local changes). This brings the.stamphog/policy extraction, author familiarity, manifest-risk scanning, sticky non-approve comments, bot-author hard gate, in-flight reviewer-bot waits, provenance trailers and thetools/ownersresolver package. The workflow is updated to match, keeping this repo's local differences:Stamphoglabel,mainref and approvals posted bygithub-actions[bot](the identity confirmed to count toward our branch ruleset). All local changes are documented in the vendored README per the upstream protocol.On top of the sync,
size_gate.max_linesgoes to 1200 (was 1000 locally, 800 upstream).How did you test this?
pytest tools/pr-approval-agent(439 passed) andpytest tools/owners/tests(92 passed)uv run tools/pr-approval-agent/review_pr.py 3666 --dry-runagainst this repo: gates, policy load and the no-ownership-files path all work end to endAutomatic notifications